Opened 5 years ago

Closed 5 years ago

#17529 closed enhancement (fixed)

Upgrade latte_int to 1.7.2 and use an unmodified upsteam tarball

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.5
Component: packages: experimental Keywords:
Cc: Merged in:
Authors: Dima Pasechnik, Thierry Monteil Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: f0f231d (Commits) Commit: f0f231d3ec2a67191da2746b17f56db54068a628
Dependencies: Stopgaps:

Description (last modified by tmonteil)

Time to update: https://www.math.ucdavis.edu/~latte/software.php

Update the license to GPLv2 (not v3).

The Sage package now uses the upstream tarball without modification.

The upstream tarball is here: https://www.math.ucdavis.edu/~latte/software/packages/latte_current/latte-int-1.7.2.tar.gz

It should be renamed latte_int-1.7.2.tar.gz within SAGE_ROOT/upstream/

Change History (24)

comment:1 Changed 5 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/17529
  • Commit set to 081be093f14248cbe864b09e64c37b87ff021990

New commits:

081be09updated latte_int to 1.7.2

comment:2 Changed 5 years ago by dimpase

  • Description modified (diff)
  • Status changed from new to needs_review

builds with SAGE_CHECK on.

comment:3 follow-ups: Changed 5 years ago by ncohen

Hello !

Can you tell me which commands you used to turn the original file into your bz2 file ?

When I do the same I get a different hash. Theoretically, that makes me suspect you from having inserted dangerous code inside of the binary :-P

https://www.math.ucdavis.edu/~latte/software/packages/latte_current/

Nathann

comment:4 Changed 5 years ago by ncohen

By the way, I believe that we are now advised to remove the 'history' section from the SPKG, as the commits are now all part of Sage's history.

Nathann

comment:5 Changed 5 years ago by ncohen

that's why you will find some spkg-src files in other directories, btw. Makes it easier to check.

Nathann

comment:6 in reply to: ↑ 3 ; follow-up: Changed 5 years ago by dimpase

Replying to ncohen:

Hello !

Can you tell me which commands you used to turn the original file into your bz2 file ?

When I do the same I get a different hash. Theoretically, that makes me suspect you from having inserted dangerous code inside of the binary :-P

I have to rename the directory latte-int***/ to latte_int***/ (because currently we cannot handle two or more dashes in the filename of the upstream tarball). And then different tar/bzip2 versions may produce different files...

Last edited 5 years ago by dimpase (previous) (diff)

comment:7 in reply to: ↑ 3 Changed 5 years ago by dimpase

Replying to ncohen:

Hello !

Can you tell me which commands you used to turn the original file into your bz2 file ?

When I do the same I get a different hash. Theoretically, that makes me suspect you from having inserted dangerous code inside of the binary :-P

you might untar and compare the filetrees, right? :-) OK, I took the tar bundle here: https://www.math.ucdavis.edu/~latte/software/packages/latte_current/latte-integrale-1.7.2.tar.gz untarred it, then untarred the latte-int-1.7.2 tarball there, renamed the resulting directory latte_int-1.7.2, and tarred it. This is as described in SPKG.txt.

I didn't bother to check the contents of the following:

https://www.math.ucdavis.edu/~latte/software/packages/latte_current/

but the tarball latte-int-1.7.2 there has the same md5 hash as the one in the bundle mentioned above.

Last edited 5 years ago by dimpase (previous) (diff)

comment:8 follow-up: Changed 5 years ago by ncohen

Okay, I checked it with "diff -r" in the end :-)

No problem with the branch, and I could compile the spkg too. Could you drop the changelog, though ? It is not part of the 'new style' standard for SPKG.txt.

By the way, could you tell me where in Sage this spkg is used ? O_o

Nathann

comment:9 Changed 5 years ago by git

  • Commit changed from 081be093f14248cbe864b09e64c37b87ff021990 to c40ab1866fa0cd4c26a6fb49e8ee3e7cfd0df35b

Branch pushed to git repo; I updated commit sha1. New commits:

c40ab18removed changelog, as asked on #17529

comment:10 Changed 5 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Okayyyyyy thanks !

Nathann

comment:11 in reply to: ↑ 8 ; follow-up: Changed 5 years ago by dimpase

  • Reviewers Nathann Cohen deleted

Replying to ncohen:

Okay, I checked it with "diff -r" in the end :-)

No problem with the branch, and I could compile the spkg too. Could you drop the changelog, though ? It is not part of the 'new style' standard for SPKG.txt.

done.

By the way, could you tell me where in Sage this spkg is used ? O_o

Nowhere at the moment -- I'd like to get a student to work on an interface to it for integer point counting in polytopes.

comment:12 in reply to: ↑ 11 Changed 5 years ago by ncohen

Nowhere at the moment -- I'd like to get a student to work on an interface to it for integer point counting in polytopes.

Well, couldn't you do that yourself ? Writing an interface is not a lot of work, really. It would definitely be easier than explaining it to a student :-P

Nathann

comment:13 in reply to: ↑ 6 ; follow-up: Changed 5 years ago by tmonteil

  • Status changed from positive_review to needs_info

Replying to dimpase:

I have to rename the directory latte-int***/ to latte_int***/ (because currently we cannot handle two or more dashes in the filename of the upstream tarball). And then different tar/bzip2 versions may produce different files...

It why not just renaming the upstream latte-int-1.7.2.tar.gz to latte_int-1.7.2.tar.gz, this will have the benefit to keep the hashsum intact ?

comment:14 Changed 5 years ago by ncohen

  • Reviewers set to Nathann Cohen

comment:15 in reply to: ↑ 13 Changed 5 years ago by dimpase

  • Status changed from needs_info to positive_review

Replying to tmonteil:

Replying to dimpase:

I have to rename the directory latte-int***/ to latte_int***/ (because currently we cannot handle two or more dashes in the filename of the upstream tarball). And then different tar/bzip2 versions may produce different files...

It why not just renaming the upstream latte-int-1.7.2.tar.gz to latte_int-1.7.2.tar.gz, this will have the benefit to keep the hashsum intact ?

the path to the source code of the package has to match the name of the tarfile.

comment:16 Changed 5 years ago by tmonteil

  • Status changed from positive_review to needs_work
  • Summary changed from upgrade latte_int to 1.7.2 to Upgrade latte_int to 1.7.2 and use an unmodified upsteam tarball

comment:17 Changed 5 years ago by tmonteil

  • Branch changed from u/dimpase/17529 to u/tmonteil/17529

comment:18 Changed 5 years ago by tmonteil

  • Authors changed from Dima Pasechnik to Dima Pasechnik, Thierry Monteil
  • Description modified (diff)
  • Status changed from needs_work to needs_review

I uploaded a proposition to keep the upstream tarball intact. I took the opportunity to update the license (which is claimed GPLv2 on their doc) and remove spkg-maintainer as discussed here (gmane) and progressively done on other packages.

comment:19 Changed 5 years ago by git

  • Commit changed from c40ab1866fa0cd4c26a6fb49e8ee3e7cfd0df35b to f0f231d3ec2a67191da2746b17f56db54068a628

Branch pushed to git repo; I updated commit sha1. New commits:

2502eed#17529 : use the upstream tarball without modifying it
f0f231d#17529 : update SPKG update instructions, license, and remove maintainer.

comment:20 Changed 5 years ago by tmonteil

Sorry i forgot to commit before pushing.

comment:21 Changed 5 years ago by dimpase

  • Status changed from needs_review to positive_review

OK, looks good

comment:22 follow-up: Changed 5 years ago by kcrisman

How might this affect our polymake tickets - orthogonal? I seem to recall latte was an extension or something of polymake but that is probably wrong...

comment:23 in reply to: ↑ 22 Changed 5 years ago by dimpase

Replying to kcrisman:

How might this affect our polymake tickets - orthogonal? I seem to recall latte was an extension or something of polymake but that is probably wrong...

Polymake can use lattE, sure, but lattE does not depend on it.

comment:24 Changed 5 years ago by vbraun

  • Branch changed from u/tmonteil/17529 to f0f231d3ec2a67191da2746b17f56db54068a628
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.