Opened 8 years ago

Closed 8 years ago

#17525 closed defect (fixed)

Maxima fails to build when Automake 1.11 is not installed

Reported by: Peter Bruin Owned by:
Priority: blocker Milestone: sage-6.5
Component: packages: standard Keywords: maxima automake
Cc: Ralf Stephan, François Bissey Merged in:
Authors: Peter Bruin Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 9827d31 (Commits, GitHub, GitLab) Commit: 9827d31e33f026d9f72023c00017b64e600c3723
Dependencies: Stopgaps:

Status badges

Description

As discussed on sage-release, the latest Maxima upgrade (#17514) inadvertently introduced a dependency on Automake 1.11. This is caused by build/pkgs/maxima/patches/makeinfo.patch, which patches a Makefile.am but not the corresponding Makefile.in.

Change History (16)

comment:1 Changed 8 years ago by Peter Bruin

Branch: u/pbruin/17525-maxima_automake
Commit: 9827d31e33f026d9f72023c00017b64e600c3723
Status: newneeds_review

comment:2 Changed 8 years ago by Jeroen Demeyer

Priority: criticalblocker

comment:3 Changed 8 years ago by François Bissey

I feel responsible for missing that in the previous ticket, but it should preferably be tested with someone that doesn't have automake installed.

comment:4 Changed 8 years ago by Jeroen Demeyer

Ideally, errors like these should be tested on the buildbot (I used to do that).

comment:5 Changed 8 years ago by François Bissey

Looks like I can test it on my macbook, I didn't do that with the original ticket. But I feel stupid to have missed that in the review, it's probably the fact that I don't need to worry about it with ebuilds in Gentoo.

comment:6 Changed 8 years ago by Volker Braun

will be tested on my osx buildbot but its still in a moving box....

comment:7 Changed 8 years ago by François Bissey

Building from scratch with included patch is in progress here.

comment:8 Changed 8 years ago by François Bissey

Bother, the mac has makeinfo so it is not really fully tested. Once the build is finished I'll hide makeinfo and rebuild maxima.

comment:9 in reply to:  3 Changed 8 years ago by Peter Bruin

Replying to fbissey:

I feel responsible for missing that in the previous ticket

No need to; as they say, "the author takes responsibility for any remaining mistakes"...

comment:10 Changed 8 years ago by François Bissey

Reviewers: François Bissey
Status: needs_reviewpositive_review

Success

/bin/sh /Users/fbissey/build/sage-6.5.beta3/local/var/tmp/sage/build/maxima-5.35.1.p1/src/missing --run makeinfo --split-size=1000000 maxima.texi
pattern=`printf "\t"` ; \
	bad_files=`find . -name '*.texi' -print | xargs /usr/bin/grep -E -l -e "$pattern"` ; \
	[ -z  "$bad_files" ] || ( echo "WARNING: The following files have unexpanded Tabs: $bad_files" ; \
	echo "Run /doc/info/fix_tab to fix the problem." )
/Users/fbissey/build/sage-6.5.beta3/local/var/tmp/sage/build/maxima-5.35.1.p1/src/missing: line 52: makeinfo: command not found
WARNING: `makeinfo' is missing on your system.  You should only need it if
         you modified a `.texi' or `.texinfo' file, or any other file
         indirectly affecting the aspect of the manual.  The spurious
         call might also be the consequence of using a buggy `make' (AIX,
         DU, IRIX).  You might want to install the `Texinfo' package or
         the `GNU make' package.  Grab either from any GNU archive site.

but everything go through to the end.

comment:11 Changed 8 years ago by Peter Bruin

Yes, that is what I get too. The fact that makeinfo needs to be run when installing Maxima out of the box is an upstream bug, I guess.

comment:12 in reply to:  11 ; Changed 8 years ago by François Bissey

Replying to pbruin:

Yes, that is what I get too. The fact that makeinfo needs to be run when installing Maxima out of the box is an upstream bug, I guess.

I had a long conversation with David Kirkby when I introduced the "touch" trick way back when the problem appeared, I am not sure it is all on trac but at the time upstream was a bit confused that there was a problem. It was like they didn't really use the "install" target.

comment:13 in reply to:  12 Changed 8 years ago by Peter Bruin

Replying to fbissey:

Replying to pbruin:

Yes, that is what I get too. The fact that makeinfo needs to be run when installing Maxima out of the box is an upstream bug, I guess.

I had a long conversation with David Kirkby when I introduced the "touch" trick way back when the problem appeared, I am not sure it is all on trac but at the time upstream was a bit confused that there was a problem. It was like they didn't really use the "install" target.

There is indeed a long discussion about this on #10773. I don't know precisely why the "touch" trick stopped working; perhaps make clobbers some dependencies of maxima.info. Anyway, the current fix seems to work as well.

comment:14 Changed 8 years ago by François Bissey

The current fix is superior. In fact we probably won't notice when it stopped being necessary - if it ever happens.

comment:15 Changed 8 years ago by Peter Bruin

I must have concluded too hastily that the "touch" trick stopped working. I checked again (by removing makeinfo.patch and reinstating the "touch" code) and everything worked fine, even when touching only maxima.info. So it seems that the only problem is that maxima.info depends on include-maxima.texi, which is generated by configure.

comment:16 Changed 8 years ago by Volker Braun

Branch: u/pbruin/17525-maxima_automake9827d31e33f026d9f72023c00017b64e600c3723
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.