Opened 5 years ago

Closed 5 years ago

#17519 closed enhancement (fixed)

PARI bindings for Galois theory

Reported by: gagern Owned by:
Priority: major Milestone: sage-6.5
Component: number theory Keywords:
Cc: Merged in:
Authors: Martin von Gagern Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: a944e8a (Commits) Commit: a944e8a627da0a3ca837f9a94712a77720577476
Dependencies: Stopgaps:

Description

Working on #17516 I found that there is no Sage binding for the following PARI functions:

Adding them along the lines of existing bindings is easy.

Change History (11)

comment:1 Changed 5 years ago by gagern

  • Branch set to u/gagern/ticket/17519
  • Created changed from 12/17/14 15:26:57 to 12/17/14 15:26:57
  • Modified changed from 12/17/14 15:26:57 to 12/17/14 15:26:57

comment:2 Changed 5 years ago by gagern

  • Commit set to 5c603c4a74e07cfaf4a6d2b205ac63c9b141eccf
  • Status changed from new to needs_review

New commits:

5c603c4PARI bindings for Galois theory

comment:3 Changed 5 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to needs_work

The code looks good to me. However, all new code is required to have documentation and tests; could you add this (maybe partly using the GP documentation)?

comment:4 Changed 5 years ago by git

  • Commit changed from 5c603c4a74e07cfaf4a6d2b205ac63c9b141eccf to cf330ff97822b4a9079d5773fcc1de8cb5d29148

Branch pushed to git repo; I updated commit sha1. New commits:

e06015dFix mismatch between pari_catch_sig_on and pari_catch_sig_off.
cf330ffAdded documentation for Galois methods.

comment:5 Changed 5 years ago by gagern

  • Status changed from needs_work to needs_review

comment:6 Changed 5 years ago by git

  • Commit changed from cf330ff97822b4a9079d5773fcc1de8cb5d29148 to 5f0493665b91fc82bc0b00de6132756f2ee55f84

Branch pushed to git repo; I updated commit sha1. New commits:

5f04936Add myself as an author, and fixed indentation.

comment:7 Changed 5 years ago by pbruin

  • Branch changed from u/gagern/ticket/17519 to u/pbruin/17519-pari_galois_functions
  • Commit changed from 5f0493665b91fc82bc0b00de6132756f2ee55f84 to 4857812fd0c08bc261da6a8c50ca81e5016f6371

The reviewer patch only makes a number of changes to the formatting and phrasing of the docstrings. If you agree with these, feel free to set this ticket to positive review.

comment:8 Changed 5 years ago by gagern

  • Branch changed from u/pbruin/17519-pari_galois_functions to u/gagern/ticket/17519
  • Modified changed from 12/18/14 15:42:03 to 12/18/14 15:42:03

comment:9 Changed 5 years ago by gagern

  • Commit changed from 4857812fd0c08bc261da6a8c50ca81e5016f6371 to a944e8a627da0a3ca837f9a94712a77720577476

I changed some things as well. Mostly a missing colon in some method reference. But while I was at it I unified formatting of lists, to have the flag distinctions match input parameter descriptions. I'll leave throwing the review switch to you now.


New commits:

a944e8aMinor fixes for consistency and formatting.

comment:10 Changed 5 years ago by pbruin

  • Status changed from needs_review to positive_review

comment:11 Changed 5 years ago by vbraun

  • Branch changed from u/gagern/ticket/17519 to a944e8a627da0a3ca837f9a94712a77720577476
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.