Opened 4 years ago

Closed 4 years ago

#17518 closed enhancement (fixed)

remove ambiguous incompatibility between coeffs() and coefficients()

Reported by: john_perry Owned by:
Priority: major Milestone: sage-6.5
Component: commutative algebra Keywords: polynomial coeffs coefficients
Cc: rws Merged in:
Authors: John Perry Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: bb4a957 (Commits) Commit: bb4a957ea6838b11b8ec8162dc657e215dfa3dc5
Dependencies: Stopgaps:

Description

This ticket adds a sparse parameter to the coefficients() method of the Polynomial class, and deprecates the use of coeffs() in a manner inconsistent with coefficients(), keeping with the discussion at https://groups.google.com/forum/#!topic/sage-devel/IHirUHTWnuA. See also trac #17438.

Change History (9)

comment:1 Changed 4 years ago by rws

  • Cc rws added

comment:2 Changed 4 years ago by john_perry

  • Branch set to u/john_perry/coeffs_confusion_polynomials
  • Cc rws removed

comment:3 Changed 4 years ago by git

  • Commit set to b48c35e949b06fccb5aff62ae5462f118b91a458

Branch pushed to git repo; I updated commit sha1. New commits:

b48c35epreliminary patch; main work done but a lot of doctests to go

comment:4 Changed 4 years ago by john_perry

  • Cc rws added

I'm still working on this; I wanted to push my commits for the time being. I'm pretty sure it only needs additional doctests, but if anyone wants to go ahead & look at the documentation & doctests of polynomial_element.pyx and polynomial_element_generic.py, it would be convenient for me to fix any problems with them tonight or tomorrow. :-)

PS: Sorry about removing the CC: earlier. It's nothing personal; I'm just clumsy.

comment:5 Changed 4 years ago by git

  • Commit changed from b48c35e949b06fccb5aff62ae5462f118b91a458 to bb4a957ea6838b11b8ec8162dc657e215dfa3dc5

Branch pushed to git repo; I updated commit sha1. New commits:

bb4a957completed modifications due to doctests

comment:6 Changed 4 years ago by john_perry

  • Status changed from new to needs_review

I've found all the doctests in need of modification that I can find, so, I think this is ready for review.

comment:7 Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Looks fine, doesn't clash with #17438, and passes make ptestlong. Please adapt the Author: field.

comment:8 Changed 4 years ago by john_perry

  • Authors changed from john_perry to John Perry

Thanks!

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/john_perry/coeffs_confusion_polynomials to bb4a957ea6838b11b8ec8162dc657e215dfa3dc5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.