Opened 5 years ago

Closed 4 years ago

#17496 closed enhancement (fixed)

Implement a check for formality for hyperplane arrangements

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-6.9
Component: geometry Keywords: hyperplane arrangements, formality
Cc: vbraun, Stefan, chapoton, dperkinson, dimpase, kcrisman Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 45e9685 (Commits) Commit: 45e9685ab5d01440a3e2cbea033f9e797eda2456
Dependencies: Stopgaps:

Description (last modified by tscrim)

Implement methods of hyperplane arrangements to construct the matroid of an arrangement, determine the minimal k such that an arrangement is k-generated, and formality of an arrangement.

Change History (17)

comment:1 Changed 5 years ago by tscrim

  • Branch set to public/geometry/formal_hyperplane_arrangements-17496
  • Cc vbraun Stefan chapoton dperkinson dimpase added
  • Commit set to 56d27553989dc42a9563628e545f08eb874ac15f
  • Description modified (diff)
  • Keywords hyperplane arrangements formality added
  • Status changed from new to needs_review

I called the method to determine the minimal k minimal_generated_number, but I'm not sure this is the best name, so suggestions welcomed.


New commits:

924d341Added check for formality, k-generated, and matroid methods.
56d2755Some cleanup.

comment:2 Changed 5 years ago by git

  • Commit changed from 56d27553989dc42a9563628e545f08eb874ac15f to cd37cc6e312d7b028024c6fff4778f73c557636b

Branch pushed to git repo; I updated commit sha1. New commits:

5179671Merge branch 'public/geometry/formal_hyperplane_arrangements-17496' of trac.sagemath.org:sage into public/geometry/formal_hyperplane_arrangements-17496
cd37cc6Fix a docstring.

comment:3 Changed 5 years ago by kcrisman

  • Cc kcrisman added

comment:4 Changed 5 years ago by chapoton

typo in "as the linear matoid"

comment:5 Changed 5 years ago by chapoton

  • Milestone changed from sage-6.5 to sage-6.9
  • Status changed from needs_review to needs_work

comment:6 Changed 5 years ago by git

  • Commit changed from cd37cc6e312d7b028024c6fff4778f73c557636b to 83d60c416226061858eb17f1792345639078ff87

Branch pushed to git repo; I updated commit sha1. New commits:

2d0656cMerge branch 'public/geometry/formal_hyperplane_arrangements-17496' in 6.9.rc0
83d60c4trac #17946 fixing two typoes

comment:7 Changed 5 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:8 Changed 5 years ago by tscrim

Thanks Frédéric; I had completely forgotten about this. Your changes are good with me. Are you able to finish the review?

comment:9 follow-up: Changed 5 years ago by chapoton

Is this a definition:

+        A hyperplane arrangement is *formal* if it is 3-generated as
+        defined in :meth:`minimal_generated_number`.

If yes, this should be stated, and with a ref.

comment:10 Changed 5 years ago by git

  • Commit changed from 83d60c416226061858eb17f1792345639078ff87 to 5f8ee7921401ca77960ac7afc7cf9af62e8b8a6c

Branch pushed to git repo; I updated commit sha1. New commits:

5f8ee79Added reference and minor tweaks.

comment:11 in reply to: ↑ 9 Changed 5 years ago by tscrim

Replying to chapoton:

Is this a definition:

+        A hyperplane arrangement is *formal* if it is 3-generated as
+        defined in :meth:`minimal_generated_number`.

If yes, this should be stated, and with a ref.

Yes, and I've added a reference.

comment:12 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good to me.

comment:13 Changed 5 years ago by tscrim

Thanks for doing the review.

comment:14 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work
LaTeX Warning: Hyper reference `sage/geometry/hyperplane_arrangement/arrangemen
t:rs' on page 309 undefined on input line 28134.

! Undefined control sequence.
l.28166 ...$-\emph{generated} if $\dim W_k = \rank
                                                   A$.
? 
! Emergency stop.
l.28166 ...$-\emph{generated} if $\dim W_k = \rank
                                                   A$.
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on geometry.log.
Makefile:55: recipe for target 'geometry.pdf' failed
make[2]: *** [geometry.pdf] Error 1

comment:15 Changed 4 years ago by git

  • Commit changed from 5f8ee7921401ca77960ac7afc7cf9af62e8b8a6c to 45e9685ab5d01440a3e2cbea033f9e797eda2456

Branch pushed to git repo; I updated commit sha1. New commits:

fe892e0Merge branch 'public/geometry/formal_hyperplane_arrangements-17496' into 6.9
45e9685trac #17496 fixing the pdf doc

comment:16 Changed 4 years ago by chapoton

  • Status changed from needs_work to positive_review

sorry. Here is a corrected version.

comment:17 Changed 4 years ago by vbraun

  • Branch changed from public/geometry/formal_hyperplane_arrangements-17496 to 45e9685ab5d01440a3e2cbea033f9e797eda2456
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.