Opened 5 years ago

Closed 5 years ago

#17465 closed enhancement (fixed)

Remove sage-crap script

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.5
Component: scripts Keywords:
Cc: was Merged in:
Authors: Jeroen Demeyer Reviewers: William Stein, Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: 5b7363d (Commits) Commit: 5b7363de53d56b9baed999a6c9ab51bac31c196f
Dependencies: Stopgaps:

Description

Remove this obsolete script from Sage.

Change History (10)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17465
  • Created changed from 12/08/14 09:31:49 to 12/08/14 09:31:49
  • Modified changed from 12/08/14 09:31:49 to 12/08/14 09:31:49

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 5b7363de53d56b9baed999a6c9ab51bac31c196f
  • Status changed from new to needs_review

New commits:

5b7363dRemove obsolete sage-crap script

comment:3 follow-up: Changed 5 years ago by kcrisman

I don't have a problem with removing - just curious why it's obsolete, since presumably it was to detect things like Mac .DS_Store files or upstream binary files or something. Does the git transition and reorganization of the files make this unnecessary?

comment:4 in reply to: ↑ 3 Changed 5 years ago by jdemeyer

Replying to kcrisman:

Does the git transition and reorganization of the files make this unnecessary?

Essentially yes. The Sage tarball is made in a much better way than it used to be, using git indeed.

comment:5 follow-up: Changed 5 years ago by kcrisman

  • Cc was added

I'm happy with this, but I'd feel more comfortable if William said "go for it", since I think he's one of the only people who ever really used it...

comment:6 in reply to: ↑ 5 Changed 5 years ago by jdemeyer

Replying to kcrisman:

he's one of the only people who ever really used it...

That should even be an extra indication that it can be removed...

comment:7 Changed 5 years ago by was

Go for it! The project that required this functionality is over.

comment:8 Changed 5 years ago by kcrisman

  • Reviewers set to William Stein, Karl-Dieter Crisman

Awesome. Let me just check this merges, though given the author I have no doubts :)

comment:9 Changed 5 years ago by kcrisman

  • Status changed from needs_review to positive_review

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17465 to 5b7363de53d56b9baed999a6c9ab51bac31c196f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.