Opened 5 years ago
Closed 5 years ago
#17463 closed defect (fixed)
Remove the deprecated 'dim' argument of MIP variables
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.7 |
Component: | numerical | Keywords: | |
Cc: | dimpase | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | d3c8f90 (Commits) | Commit: | d3c8f902e77b87fb1a1f6406d04a04127683f452 |
Dependencies: | Stopgaps: |
Description (last modified by )
The 'dim' attribute of MIPVariables has been deprecated since Sage 6.2 in
#15489. It was always useless since myvar[a,b]
works and is more practical
than myvar[a][b]
. I had not noticed that when I implemented it
T_T
With this ticket, the problem is solved.
Change History (17)
comment:1 Changed 5 years ago by
- Branch set to u/ncohen/17463
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Commit set to d3c8f902e77b87fb1a1f6406d04a04127683f452
comment:4 Changed 5 years ago by
Thanks !
Nathann
comment:5 Changed 5 years ago by
- Description modified (diff)
- Milestone changed from sage-6.5 to sage-pending
comment:6 Changed 5 years ago by
- Summary changed from Remove the (deprecate) 'dim' argument of MIP variables to Remove the deprecated 'dim' argument of MIP variables
comment:7 Changed 5 years ago by
I hope you don't expect me to merge "sage-pending" tickets...
comment:8 Changed 5 years ago by
I do not object to changing the milestone and having it merged tomorrow, if you ask.
Nathann
comment:9 Changed 5 years ago by
I'm neither the author nor the reviewer (name missing btw).
comment:10 Changed 5 years ago by
- Reviewers set to Dima Pasechnik
comment:11 follow-up: ↓ 12 Changed 5 years ago by
PSA: Once you want the ticket merged you can set a milestone to something else than "sage-pending"
comment:12 in reply to: ↑ 11 Changed 5 years ago by
PSA: Once you want the ticket merged you can set a milestone to something else than "sage-pending"
Right right. I asked google calendar to send me an email on the 2015-05-06.
Nathann
comment:13 Changed 5 years ago by
Just trying to make sure that everybody understands that feature of the merge script since it caused some confusion on another ticket
comment:14 Changed 5 years ago by
- Milestone changed from sage-pending to sage-6.7
comment:15 Changed 5 years ago by
Oh. Thanks :-D
comment:16 Changed 5 years ago by
- Description modified (diff)
comment:17 Changed 5 years ago by
- Branch changed from u/ncohen/17463 to d3c8f902e77b87fb1a1f6406d04a04127683f452
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Removed 'MIPVariable.dim' attribute deprecated in #15489 on 2013-12-06