Opened 5 years ago

Closed 5 years ago

#17458 closed defect (fixed)

import_statements should ignore lazy imports with deprecation

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 528e64a (Commits) Commit: 528e64a33c3d3267d0a5e4e8531bad6a1d16a05e
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

After this ticket import_statements will ignore lazy imports (and raise a LookupError if only deprecated objects are found).

Change History (8)

comment:1 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17458
  • Created changed from 12/07/14 20:55:24 to 12/07/14 20:55:24
  • Modified changed from 12/07/14 22:35:43 to 12/07/14 22:35:43

comment:3 Changed 5 years ago by jdemeyer

  • Commit set to 0321aa107fbd1900345b89c6e4bd0b47523bdb27
  • Status changed from new to needs_review

New commits:

0321aa1import_statements should ignore deprecated lazy imports

comment:4 Changed 5 years ago by vdelecroix

  • Branch changed from u/jdemeyer/ticket/17458 to u/vdelecroix/17458
  • Commit changed from 0321aa107fbd1900345b89c6e4bd0b47523bdb27 to 4058557aeb437667548d9614f6ea98eb1458865b
  • Description modified (diff)

Hello,

I added the trac ticket number to the LookupError. I wonder why there is no specification for the _deprecation argument of LazyImport...

If you like it, you can set to positive review.

Vincent


New commits:

4058557trac #17458: add ticket number to the LookupError

comment:5 Changed 5 years ago by jdemeyer

  • Branch changed from u/vdelecroix/17458 to u/jdemeyer/ticket/17458
  • Modified changed from 12/08/14 08:27:36 to 12/08/14 08:27:36

comment:6 Changed 5 years ago by jdemeyer

  • Commit changed from 4058557aeb437667548d9614f6ea98eb1458865b to 528e64a33c3d3267d0a5e4e8531bad6a1d16a05e
  • Reviewers set to Vincent Delecroix

I think it's a good idea to add the ticket number, but then we might as well always return the ticket when asking for the deprecation (since 0 is False in a boolean context, this works as expected). Needs review.


New commits:

528e64aRename _is_deprecated() as _get_deprecation_ticket()

comment:7 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to positive_review

Perfect!

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17458 to 528e64a33c3d3267d0a5e4e8531bad6a1d16a05e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.