Opened 3 years ago
Closed 3 years ago
#17429 closed defect (fixed)
projective point equality returns false positive for ComplexIntervalField
Reported by:  bhutz  Owned by:  bhutz 

Priority:  major  Milestone:  sage6.5 
Component:  algebraic geometry  Keywords:  
Cc:  Merged in:  
Authors:  Ben Hutz  Reviewers:  Grayson Jorgenson 
Report Upstream:  N/A  Work issues:  
Branch:  6aa86f9 (Commits)  Commit:  6aa86f947c9d8b51542b5d8c875f79fc0b004644 
Dependencies:  #17324  Stopgaps: 
Description
Projective equality is returning false positives for ComplexIntervalField? points because it is doing a negative check not a positive check
R.<x>=PolynomialRing(QQ) r=(x^2x3).polynomial(x).roots(ComplexIntervalField(),multiplicities=False) P.<x,y>=ProjectiveSpace(ComplexIntervalField(),1) P1=P(r[0],1) H=End(P) f = H([x^23*y^2,y^2]) Q1=f(P1) Q1==P1, Q1[0]==P1[0]
This is likely an issue for both points and morphisms.
Change History (11)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
 Branch set to u/bhutz/ticket/17429
 Created changed from 12/01/14 21:15:24 to 12/01/14 21:15:24
 Modified changed from 12/02/14 03:52:04 to 12/02/14 03:52:04
comment:3 Changed 3 years ago by
 Commit set to b20353c382e1cd77fa5e34092a7989253e9a9e67
 Dependencies set to 17324
 Status changed from new to needs_review
comment:4 Changed 3 years ago by
 Dependencies changed from 17324 to #17324
comment:5 Changed 3 years ago by
 Status changed from needs_review to positive_review
comment:6 Changed 3 years ago by
 Status changed from positive_review to needs_review
comment:7 Changed 3 years ago by
Just two minor typos in projective_point __eq__
, __ne__
, projective is spelled wrong
comment:8 Changed 3 years ago by
 Commit changed from b20353c382e1cd77fa5e34092a7989253e9a9e67 to ae4317a3ad0c946133c13fa44a51bf681e465fa4
Branch pushed to git repo; I updated commit sha1. New commits:
ae4317a  17429: fixed typos

comment:9 Changed 3 years ago by
 Commit changed from ae4317a3ad0c946133c13fa44a51bf681e465fa4 to 6aa86f947c9d8b51542b5d8c875f79fc0b004644
Branch pushed to git repo; I updated commit sha1. New commits:
6aa86f9  Merge branch 'master' into ticket/17429

comment:10 Changed 3 years ago by
 Reviewers set to Grayson Jorgenson
 Status changed from needs_review to positive_review
Looks good. I can't find any additional typos, and the doctests pass
comment:11 Changed 3 years ago by
 Branch changed from u/bhutz/ticket/17429 to 6aa86f947c9d8b51542b5d8c875f79fc0b004644
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
(related to #17427)