Opened 6 years ago

Closed 6 years ago

#17429 closed defect (fixed)

projective point equality returns false positive for ComplexIntervalField

Reported by: bhutz Owned by: bhutz
Priority: major Milestone: sage-6.5
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Ben Hutz Reviewers: Grayson Jorgenson
Report Upstream: N/A Work issues:
Branch: 6aa86f9 (Commits) Commit: 6aa86f947c9d8b51542b5d8c875f79fc0b004644
Dependencies: #17324 Stopgaps:

Description

Projective equality is returning false positives for ComplexIntervalField? points because it is doing a negative check not a positive check 

R.<x>=PolynomialRing(QQ)
r=(x^2-x-3).polynomial(x).roots(ComplexIntervalField(),multiplicities=False)
P.<x,y>=ProjectiveSpace(ComplexIntervalField(),1)
P1=P(r[0],1)
H=End(P)
f = H([x^2-3*y^2,y^2])
Q1=f(P1)
Q1==P1, Q1[0]==P1[0]

This is likely an issue for both points and morphisms.

Change History (11)

comment:1 Changed 6 years ago by ncohen

(related to #17427)

comment:2 Changed 6 years ago by bhutz

  • Branch set to u/bhutz/ticket/17429
  • Created changed from 12/01/14 21:15:24 to 12/01/14 21:15:24
  • Modified changed from 12/02/14 03:52:04 to 12/02/14 03:52:04

comment:3 Changed 6 years ago by bhutz

  • Authors set to Ben Hutz
  • Commit set to b20353c382e1cd77fa5e34092a7989253e9a9e67
  • Dependencies set to 17324
  • Status changed from new to needs_review

New commits:

​218c56b17324: fix eq and ne for affine and projective morphisms
​a02a1e1Merge branch 'develop' of git://trac.sagemath.org/sage into ticket/17324
​b20353c17429: make == a positive check for project points and morphisms

comment:4 Changed 6 years ago by bhutz

  • Dependencies changed from 17324 to #17324

comment:5 Changed 6 years ago by gjorgenson

  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by gjorgenson

  • Status changed from positive_review to needs_review

comment:7 Changed 6 years ago by gjorgenson

Just two minor typos in projective_point __eq__, __ne__, projective is spelled wrong

comment:8 Changed 6 years ago by git

  • Commit changed from b20353c382e1cd77fa5e34092a7989253e9a9e67 to ae4317a3ad0c946133c13fa44a51bf681e465fa4

Branch pushed to git repo; I updated commit sha1. New commits:

​ae4317a17429: fixed typos

comment:9 Changed 6 years ago by git

  • Commit changed from ae4317a3ad0c946133c13fa44a51bf681e465fa4 to 6aa86f947c9d8b51542b5d8c875f79fc0b004644

Branch pushed to git repo; I updated commit sha1. New commits:

​6aa86f9Merge branch 'master' into ticket/17429

comment:10 Changed 6 years ago by gjorgenson

  • Reviewers set to Grayson Jorgenson
  • Status changed from needs_review to positive_review

Looks good. I can't find any additional typos, and the doctests pass

comment:11 Changed 6 years ago by vbraun

  • Branch changed from u/bhutz/ticket/17429 to 6aa86f947c9d8b51542b5d8c875f79fc0b004644
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.