Opened 5 years ago
Closed 4 years ago
#17411 closed enhancement (fixed)
Added colored and signed permutations
Reported by:  tscrim  Owned by:  sagecombinat 

Priority:  major  Milestone:  sage6.10 
Component:  combinatorics  Keywords:  permutations, complex reflection groups 
Cc:  sagecombinat, stumpc5, andrew.mathas, chapoton, kdilks  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Kevin Dilks 
Report Upstream:  N/A  Work issues:  
Branch:  4595847 (Commits)  Commit:  4595847bc52ffb96ebf970944c7ebc8d3347cf3c 
Dependencies:  Stopgaps: 
Description
Currently we do not have classes for colored nor signed permutations. Implemented as a group by using the wreath product construction.
Change History (22)
comment:1 Changed 5 years ago by
 Branch set to public/combinat/colored_permutation_groups17411
 Cc stumpc5 andrew.mathas chapoton added
 Commit set to 184b4f9403b613e357db74d9074c3e95e8370ce3
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
Hi Travis,
I think it is needed to have ._gap_()
implemented on all these wreath product constructions. I am trying to do that right now.
Vincent
comment:3 Changed 5 years ago by
Hey Vincent,
I agree that we probably should have a _gap_
method. Were you able to add that code?
comment:4 Changed 5 years ago by
See also #16010 for specialized code on signed permutations.
comment:5 Changed 4 years ago by
 Status changed from needs_review to needs_work
One failing doctest, see patchbot report
comment:6 Changed 4 years ago by
 Commit changed from 184b4f9403b613e357db74d9074c3e95e8370ce3 to d063050fa1e0abe4506eaa30fa911ba7791a3a97
comment:7 Changed 4 years ago by
 Status changed from needs_work to needs_review
Fixed (failure was due to Coxeter groups better understanding their category).
comment:8 Changed 4 years ago by
 Commit changed from d063050fa1e0abe4506eaa30fa911ba7791a3a97 to 5f32618962e05ffec650d973c10328ea8cc6bd85
Branch pushed to git repo; I updated commit sha1. New commits:
5f32618  trac #17411 a few doc typo corrections and also some pep8 code changes

comment:9 Changed 4 years ago by
 Commit changed from 5f32618962e05ffec650d973c10328ea8cc6bd85 to 0350849cd7f02b23156de843e2dadcead7d4baa4
comment:10 Changed 4 years ago by
 Commit changed from 0350849cd7f02b23156de843e2dadcead7d4baa4 to 0b56cd3df944345e4578570cba8df571f1a158b4
Branch pushed to git repo; I updated commit sha1. New commits:
0b56cd3  trac #17411 one typo found

comment:11 Changed 4 years ago by
 Commit changed from 0b56cd3df944345e4578570cba8df571f1a158b4 to 24b4b4fe83f7453c155714439ff255e576e5f652
Branch pushed to git repo; I updated commit sha1. New commits:
24b4b4f  trac #17411 lazy import

comment:12 Changed 4 years ago by
Let me know if what you're doing/done counts as a review and if so, when you're done (thus far, I'm good with your changes).
comment:13 Changed 4 years ago by
OOps, sorry. I just realized that I had pushed without giving my name or commenting. Yes, I am more or less doing a review. In my spare time, so this may take longer..
comment:14 Changed 4 years ago by
No worries. Thank you for all the recent reviews you have been doing.
comment:15 Changed 4 years ago by
 Cc kdilks added
comment:16 Changed 4 years ago by
Comments so far:
 Make 'number_reflecting_hyperplanes' 'number_of_reflecting_hyperplanes', because that's the way permutation statistics names methods.
 Documentation should mention somewhere that \ell is the number of degrees is the rank. Some docstrings just refer to \ell, and maybe you could look back and see that \ell is the number of degrees, but then nothing mentions that the number of the degrees is the same as the rank.
 Why just left descent and not right descent?
 Colored permutations should have an inverse operation.
 There should be element constructors
ColoredPermutation
andSignedPermutation
.  For
m=2
, there should be a way to get between thinking of something as aSignedPermutation
and aColoredPermutation
.  Codegree documentation needs a
.. Math::
around the formula.  Preliminary docstring/index of functions would be nice, but possibly a task for another ticket.
comment:17 Changed 4 years ago by
 Status changed from needs_review to needs_work
comment:18 Changed 4 years ago by
 Commit changed from 24b4b4fe83f7453c155714439ff255e576e5f652 to 4595847bc52ffb96ebf970944c7ebc8d3347cf3c
comment:19 Changed 4 years ago by
 Milestone changed from sage6.5 to sage6.10
 Status changed from needs_work to needs_review
comment:20 Changed 4 years ago by
 Status changed from needs_review to positive_review
comment:21 Changed 4 years ago by
 Reviewers set to Kevin Dilks
comment:22 Changed 4 years ago by
 Branch changed from public/combinat/colored_permutation_groups17411 to 4595847bc52ffb96ebf970944c7ebc8d3347cf3c
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Initial implementation of colored permutations.
Merge branch 'develop' into public/combinat/colored_permutation_groupsTBA
Fixing things and added full coverage.
Added some more methods and some comments.