Opened 6 years ago
Closed 6 years ago
#17409 closed defect (fixed)
Random failure in sets/set.py
Reported by: | vbraun | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.5 |
Component: | misc | Keywords: | random_fail |
Cc: | Merged in: | ||
Authors: | Travis Scrimshaw | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | 82e6643 (Commits) | Commit: | 82e6643b40cb065ac32cdbb3864c2b8f0208a9b7 |
Dependencies: | #15247 | Stopgaps: |
Description
sage -t --long src/sage/sets/set.py ********************************************************************** File "src/sage/sets/set.py", line 102, in sage.sets.set.Set Failed example: sorted(Set([Sequence([3,1], immutable=True), 5, QQ, Partition([3,1,1])])) Expected: [Rational Field, [3, 1], [3, 1, 1], 5] Got: [5, Rational Field, [3, 1], [3, 1, 1]] **********************************************************************
Change History (9)
comment:1 Changed 6 years ago by
- Branch set to public/misc/random_failure_sets-17409
- Commit set to 9d8811594ce5c64bd1429054f23ed51f14ac86c7
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
thanks!
comment:3 Changed 6 years ago by
- Status changed from positive_review to needs_work
Conflicts with #15247
comment:4 Changed 6 years ago by
- Commit changed from 9d8811594ce5c64bd1429054f23ed51f14ac86c7 to e4eff58d337a36f5520d21cdf34a6f16ff5ec418
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
59aea3c | SingletonClass: Less redundant docstrings
|
765b281 | QQ/SingletonClass: Delete redundant doctest
|
dfbb8bb | Make QQbar, AA, and PariRing 'SingletonClass'es
|
4ad8e71 | Merge branch 'u/mmezzarobba/15247-singleton_class-rebased' of trac.sagemath.org:sage into public/structure/singleton_class-15247
|
0d78737 | Some review changes for #15247.
|
391421e | Merge branch 'public/singleton_class-15247' of trac.sagemath.org:sage into public/singleton_class-15247
|
3e9e736 | Fix merge error
|
3bd5ae0 | Merge branch 'public/singleton_class-15247' of trac.sagemath.org:sage into public/singleton_class-15247
|
aa9821e | Changes from Nicolas' suggestions.
|
e4eff58 | Merge branch 'public/singleton_class-15247' of trac.sagemath.org:sage into public/misc/random_failure_sets-17409
|
comment:5 Changed 6 years ago by
- Status changed from needs_work to positive_review
comment:6 Changed 6 years ago by
- Status changed from positive_review to needs_work
You lost the "key=str" in the merge.
comment:7 Changed 6 years ago by
- Commit changed from e4eff58d337a36f5520d21cdf34a6f16ff5ec418 to 82e6643b40cb065ac32cdbb3864c2b8f0208a9b7
Branch pushed to git repo; I updated commit sha1. New commits:
82e6643 | Added back in after bad merge.
|
comment:8 Changed 6 years ago by
- Dependencies set to #15247
- Status changed from needs_work to positive_review
Whoops. Fixed.
comment:9 Changed 6 years ago by
- Branch changed from public/misc/random_failure_sets-17409 to 82e6643b40cb065ac32cdbb3864c2b8f0208a9b7
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I explicitly made it sort by the string since the objects aren't intrinsically comparable.
New commits:
Made doctest deterministic in set.py.