Opened 4 years ago

Closed 4 years ago

#17407 closed enhancement (fixed)

Replace R[x] by R['x'] in doctests

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.5
Component: doctest coverage Keywords: rings, variables, names
Cc: Merged in:
Authors: Simon King, Ralf Stephan Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 0e7a1c1 (Commits) Commit: 0e7a1c1158865a3b7e9f48eb77f298786d4e97ff
Dependencies: Stopgaps:

Description

This ticket is split off from #10483 and contains the trivial doctest fixes such that we can concentrate on the less trivial stuff in #10483.

Change History (24)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17407
  • Created changed from 11/27/14 10:10:26 to 11/27/14 10:10:26
  • Modified changed from 11/27/14 10:10:26 to 11/27/14 10:10:26

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 6429596a644a251bd0d8adc664536eeb4bf5780c
  • Reviewers set to Jeroen Demeyer
  • Status changed from new to needs_review

New commits:

6429596Trac #17407: replace R[x] by R['x'] in doctests

comment:3 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:4 Changed 4 years ago by rws

  • Status changed from positive_review to needs_work

That was too fast for me, I had a commit for #10483 in the works. I'll append the missing doctest fixes from #10483 here.

comment:5 Changed 4 years ago by rws

  • Branch changed from u/jdemeyer/ticket/17407 to public/17407

comment:6 Changed 4 years ago by rws

  • Commit changed from 6429596a644a251bd0d8adc664536eeb4bf5780c to 1ffdb49721c4e283743ae08883ceadb1872aa365
  • Keywords rings variables names added
  • Status changed from needs_work to needs_review

New commits:

1ffdb4917407: more doctest fixes

comment:7 Changed 4 years ago by jdemeyer

  • Branch changed from public/17407 to u/jdemeyer/ticket/17407
  • Modified changed from 11/27/14 13:34:54 to 11/27/14 13:34:54

comment:8 Changed 4 years ago by jdemeyer

  • Commit changed from 1ffdb49721c4e283743ae08883ceadb1872aa365 to b3289a83ad3b420a5bb6989d13fbf06fe9443d22
  • Status changed from needs_review to positive_review

Since I created this ticket specifically to treat only the easy trivial cases, I undid some of your changes (I'll add them to #10483 immediately).

Positive_review to the rest.


New commits:

b3289a8Undo non-trivial changes

comment:9 Changed 4 years ago by rws

  • Branch changed from u/jdemeyer/ticket/17407 to u/rws/ticket/17407

comment:10 Changed 4 years ago by rws

  • Commit changed from b3289a83ad3b420a5bb6989d13fbf06fe9443d22 to 76c34e825a2381a7517b33c312ef9a06309866a8
  • Status changed from positive_review to needs_review

New commits:

76c34e817407: even more dotest fixes, should be all

comment:11 Changed 4 years ago by rws

  • Status changed from needs_review to positive_review

comment:12 Changed 4 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Don't review your own patches :-)

Can you please remove these changes:

sage: J = ZZ['x'].ideal(7,x)

and

sage: a = QQ[I]['x'](x)

comment:13 Changed 4 years ago by jdemeyer

For the french_book tests, it's probably better to keep the tests and simply add the deprecation message in #10483. So you should also remove those changes from this ticket.

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/rws/ticket/17407 to 76c34e825a2381a7517b33c312ef9a06309866a8
  • Resolution set to fixed
  • Status changed from needs_work to closed

comment:15 Changed 4 years ago by vbraun

  • Commit 76c34e825a2381a7517b33c312ef9a06309866a8 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

comment:16 Changed 4 years ago by rws

git ci tells me Your branch is based on 'trac/76c34e825a2381a7517b33c312ef9a06309866a8', but the upstream is gone.. So I guess Volker wants to encourage squashing of commits ;)

comment:17 follow-up: Changed 4 years ago by jdemeyer

I have no idea what that means, are you unable to push your branch to trac?

comment:18 Changed 4 years ago by rws

  • Branch changed from 76c34e825a2381a7517b33c312ef9a06309866a8 to public/17407

comment:19 in reply to: ↑ 17 Changed 4 years ago by rws

  • Commit set to d4f68b7b479e71d14f5a938b36ea2133b7d4dfed
  • Status changed from new to needs_review

Replying to jdemeyer:

I have no idea what that means, are you unable to push your branch to trac?

Volker confused me with taking back the 'fixed'.


New commits:

6429596Trac #17407: replace R[x] by R['x'] in doctests
1ffdb4917407: more doctest fixes
b3289a8Undo non-trivial changes
76c34e817407: even more dotest fixes, should be all
d4f68b717407: more fixes

comment:20 Changed 4 years ago by jdemeyer

OK, now please do not make further changes to this branch.

comment:21 Changed 4 years ago by jdemeyer

  • Branch changed from public/17407 to u/jdemeyer/ticket/17407
  • Modified changed from 11/28/14 14:30:40 to 11/28/14 14:30:40

comment:22 Changed 4 years ago by jdemeyer

  • Commit changed from d4f68b7b479e71d14f5a938b36ea2133b7d4dfed to 0e7a1c1158865a3b7e9f48eb77f298786d4e97ff

If you agree with this last commit, let's give this a definitive positive_review.


New commits:

0e7a1c1Trivial doctest reformatting

comment:23 Changed 4 years ago by rws

  • Status changed from needs_review to positive_review

comment:24 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17407 to 0e7a1c1158865a3b7e9f48eb77f298786d4e97ff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.