Opened 5 years ago

Closed 4 years ago

#17402 closed defect (fixed)

SR.power_series cannot handle symbolic series

Reported by: rws Owned by:
Priority: major Milestone: sage-7.2
Component: symbolics Keywords: conversion, ring
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 00c35cd (Commits) Commit: 00c35cdfa9e4328f099f6f95a00ab29e2cc2037f
Dependencies: #17399, #17659 Stopgaps:

Description 

sage: x=var('x')
sage: s=(1/(1-x)).series(x,6)
sage: ps=s.power_series(SR)
sage: ps
x^5 + x^4 + x^3 + x^2 + x + Order(x^6) + 1 + O(x)
sage: ps=s.power_series(QQ)
...
TypeError: unable to convert 1 + 1*x + 1*x^2 + 1*x^3 + 1*x^4 + 1*x^5 + Order(x^6) to a rational

This is analogous to #16203 and can be worked around using truncate() but really should work out of the box.

Change History (14)

comment:1 Changed 5 years ago by rws

  • Branch set to u/rws/sr_power_series_cannot_handle_symbolic_series

comment:2 Changed 5 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 6cd5286d987cf944621fb7666f1756b7785bcd0b
  • Keywords conversion ring added
  • Status changed from new to needs_review

New commits:

​32ae67c17399: do not let maxima handle ex.series coefficients
​99820cf17399: roll back previous commit to allow merge of 17428
​d7da52c17438: implement coeff list
​9452fa917438: deprecate ex.coeff/coeffs()
​0fec12917438: implement ex.list()
​168b659Merge branch 'u/rws/coefficients_of_symbolic_expressions_revamp' of trac.sagemath.org:sage into t/17399/fix_coefficients_for_symbolic_series
​6cd528617399: handle series in ex.coefficients()

comment:3 Changed 5 years ago by git

  • Commit changed from 6cd5286d987cf944621fb7666f1756b7785bcd0b to bcdb893753f2ce02eaf370b10265b2002c7f6b31

Branch pushed to git repo; I updated commit sha1. New commits:

​bcdb89317402: handle series in SR.power_series()

comment:4 Changed 5 years ago by rws

  • Dependencies set to #17399

comment:5 Changed 5 years ago by rws

  • Branch changed from u/rws/sr_power_series_cannot_handle_symbolic_series to public/17402

comment:6 Changed 5 years ago by rws

  • Commit changed from bcdb893753f2ce02eaf370b10265b2002c7f6b31 to 353612066f6a407d4428c54f18cec1611e11181b
  • Dependencies changed from #17399 to #17399, #17659

Made dependent from #17659; all squashed into one commit.

New commits:

​353612017402: merge 17659; add SymbolicSeries.power_series

comment:7 Changed 5 years ago by git

  • Commit changed from 353612066f6a407d4428c54f18cec1611e11181b to 95daf79fcc402bd691a201e0956190f4a5af94fb

Branch pushed to git repo; I updated commit sha1. New commits:

​95daf79Merge branch 'develop' into t/17402/public/17402

comment:8 Changed 4 years ago by rws

Passes all patchbot tests.

comment:9 Changed 4 years ago by rws

  • Milestone changed from sage-6.5 to sage-pending

Pending because #17659 is pending.

comment:10 Changed 4 years ago by rws

  • Branch changed from public/17402 to u/rws/17402-1

comment:11 Changed 4 years ago by rws

  • Commit changed from 95daf79fcc402bd691a201e0956190f4a5af94fb to 00c35cdfa9e4328f099f6f95a00ab29e2cc2037f
  • Milestone changed from sage-pending to sage-7.2

New commits:

​00c35cd17402: add SymbolicSeries.power_series

comment:12 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:13 Changed 4 years ago by rws

The diff shown by the branch link of this ticket is different than what I get with git trac pull into develop. I hope this is just a trac problem.

comment:14 Changed 4 years ago by vbraun

  • Branch changed from u/rws/17402-1 to 00c35cdfa9e4328f099f6f95a00ab29e2cc2037f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.