Opened 5 years ago

Closed 5 years ago

#17370 closed defect (fixed)

Setting .copy(immutable=False) everywhere

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.5
Component: graph theory Keywords:
Cc: Simon, tscrim, jmantysalo Merged in:
Authors: Nathann Cohen Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 64f5c3d (Commits) Commit: 64f5c3d90b0f473044a77b6b438f542eed7a4ef5
Dependencies: Stopgaps:

Description

After many patches which only fixed a bad call to copy() there and there, here is a patch to fix them all. Err, all that need to be fixed: I went over all of them and added this when needed.

This branch also fixes a small problem reported today by a friend of mine, i.e. an exception when trying to plot with javascript a graph whose layout is defined with "complicated" objects like rationals.

graphs.CompleteBipartiteGraph(4,5).show(method="js")

Change History (5)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17370
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 64f5c3d90b0f473044a77b6b438f542eed7a4ef5

Branch pushed to git repo; I updated commit sha1. New commits:

64f5c3dtrac #17370: Setting .copy(immutable=False) everywhere

comment:3 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

looks good to me, as far as all tests pass

comment:4 Changed 5 years ago by ncohen

THaaaaaaaaaaanks !

Nathann

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17370 to 64f5c3d90b0f473044a77b6b438f542eed7a4ef5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.