Opened 8 years ago
Closed 8 years ago
#17348 closed defect (fixed)
gcc 4.9.2 does not build on ARM
Reported by: | Volker Braun | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.5 |
Component: | build | Keywords: | |
Cc: | Merged in: | ||
Authors: | Volker Braun | Reviewers: | Jean-Pierre Flori |
Report Upstream: | N/A | Work issues: | |
Branch: | fc9920e (Commits, GitHub, GitLab) | Commit: | fc9920e24d767010a654b1b4be48f76de1b73f5e |
Dependencies: | Stopgaps: |
Description (last modified by )
Upstream bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740
Fixes it on our arm buildbot.
Change History (7)
comment:1 Changed 8 years ago by
Branch: | → u/vbraun/gcc_4_9_2_does_not_build_on_arm |
---|
comment:2 Changed 8 years ago by
Authors: | → Volker Braun |
---|---|
Commit: | → a104fe6fbdbd6f1c72c64df3ce1bfdbb653acd79 |
Description: | modified (diff) |
Status: | new → needs_review |
comment:3 Changed 8 years ago by
It's an upstream patch. So I would happily positive review it. I'll just let you argue why it's not documented in SPKG.txt first.
comment:4 Changed 8 years ago by
Branch: | u/vbraun/gcc_4_9_2_does_not_build_on_arm → u/jpflori/ticket/17348 |
---|---|
Commit: | a104fe6fbdbd6f1c72c64df3ce1bfdbb653acd79 → fc9920e24d767010a654b1b4be48f76de1b73f5e |
Reviewers: | → Jean-Pierre Flori |
Status: | needs_review → positive_review |
comment:5 Changed 8 years ago by
IMHO the patches should be documented in the patch, not in some other file. I did document it in the patch...
comment:6 Changed 8 years ago by
I kind of agree this would be better.
But as you can see, I just did it the old way as a "reviewer" commit as it was trivial.
comment:7 Changed 8 years ago by
Branch: | u/jpflori/ticket/17348 → fc9920e24d767010a654b1b4be48f76de1b73f5e |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
Add upstream patch for ARM ICE