Opened 4 years ago

Closed 4 years ago

#17348 closed defect (fixed)

gcc 4.9.2 does not build on ARM

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.5
Component: build Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: fc9920e (Commits) Commit: fc9920e24d767010a654b1b4be48f76de1b73f5e
Dependencies: Stopgaps:

Description (last modified by vbraun)

Upstream bug: ​https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Fixes it on our arm buildbot.

Change History (7)

comment:1 Changed 4 years ago by vbraun

  • Branch set to u/vbraun/gcc_4_9_2_does_not_build_on_arm

comment:2 Changed 4 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to a104fe6fbdbd6f1c72c64df3ce1bfdbb653acd79
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​a104fe6Add upstream patch for ARM ICE

comment:3 Changed 4 years ago by jpflori

It's an upstream patch. So I would happily positive review it. I'll just let you argue why it's not documented in SPKG.txt first.

comment:4 Changed 4 years ago by jpflori

  • Branch changed from u/vbraun/gcc_4_9_2_does_not_build_on_arm to u/jpflori/ticket/17348
  • Commit changed from a104fe6fbdbd6f1c72c64df3ce1bfdbb653acd79 to fc9920e24d767010a654b1b4be48f76de1b73f5e
  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_review to positive_review

New commits:

​c24897cMerge remote-tracking branch 'trac/u/vbraun/gcc_4_9_2_does_not_build_on_arm' into ticket/17348
​fc9920eDocument GCC patch for ARM.

comment:5 Changed 4 years ago by vbraun

IMHO the patches should be documented in the patch, not in some other file. I did document it in the patch...

comment:6 Changed 4 years ago by jpflori

I kind of agree this would be better.

But as you can see, I just did it the old way as a "reviewer" commit as it was trivial.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jpflori/ticket/17348 to fc9920e24d767010a654b1b4be48f76de1b73f5e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.