Opened 5 years ago

Closed 5 years ago

#17345 closed defect (fixed)

R does not build on Cygwin

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords: R cygwin
Cc: tscrim Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9e8fa71 (Commits) Commit: 9e8fa718d7a490b2af1d5465835d37d9c4d3d76e
Dependencies: #17300 Stopgaps:

Description

In src/library/parallel/src/fork.c the function parent_sig_handler is defined after it is used.

Change History (6)

comment:1 Changed 5 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/17345
  • Cc tscrim added
  • Commit set to 9e8fa718d7a490b2af1d5465835d37d9c4d3d76e
  • Dependencies set to #17300
  • Keywords R cygwin added
  • Status changed from new to needs_review

This is still needed after #17300.


New commits:

c77ca77Trac #17300: upgrade R to version 3.1.2
6f4cff5Merge remote-tracking branch 'trac/u/jdemeyer/ticket/17300' into ticket/17345
9e8fa71Let R 3.1.>=1 build on Cygwin.

comment:2 Changed 5 years ago by tscrim

Is this a Cygwin issue or is it because Cygwin is just more picky about these things (i.e., should this be submitted upstream)?

comment:3 Changed 5 years ago by jpflori

It's in an else clause picked up on Cygwin, but potentially on other systems. The definitions in the if clause which is usually picked are in the right order.

This was introduced in 3.1.1, the code in 3.1.0 is different.

And the problem here is really trivial, nothing to do with Cygwin but with the C language: you don't know anything about a function until it is defined, and defining it later on in the same file is not enough, you would need a forward declaration.

comment:4 Changed 5 years ago by jpflori

And yes, it should be reported upstream, and I think it would be better not to mention Cygwin after the response I got for #15768.

comment:5 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think you mean #15678, but yes, I wouldn't mention Cygwin. LGTM. (FTR, I'm fluent in C/C++.)

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jpflori/ticket/17345 to 9e8fa718d7a490b2af1d5465835d37d9c4d3d76e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.