Changes between Initial Version and Version 1 of Ticket #17341


Ignore:
Timestamp:
02/11/16 16:45:20 (5 years ago)
Author:
jdemeyer
Comment:

visualize_structure no longer has a filename argument.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17341

    • Property Authors changed from to Jeroen Demeyer
    • Property Summary changed from visualize_structure for matrices: behavior does not match documentation to visualize_structure for sparse matrices over GF(p) is broken
    • Property Milestone changed from sage-6.4 to sage-7.1
  • Ticket #17341 – Description

    initial v1  
    1 The docstring for `visualize_structure` (from the file `matrix/matrix2.pyx`) says that the input is
    21{{{
    3         -  ``filename`` - either a path or None in which case a
    4            filename in the current directory is chosen automatically
    5            (default:None)
     2sage: random_matrix(GF(2), 8, 586, sparse=True).visualize_structure()
     3IndexError: image index out of range
    64}}}
    7 In fact, if `filename` is None, then the file gets silently saved in a temporary directory (by default a subdirectory of `DOTSAGE/temp`), leaving the user to wonder where their file went. I guess the right thing to do is to change the docstring, since I think that's how other methods for saving graphics work.
    85
    9 (The docstring is also misformatted: `maxsize` should be in the bulleted list of inputs.)
     6Solution: remove this specialized implementation, since the general one from `Matrix` works just fine.