Changes between Initial Version and Version 15 of Ticket #17339


Ignore:
Timestamp:
12/11/19 15:02:15 (2 years ago)
Author:
gh-kliem
Comment:

I propose leaving the following as it is: 

sage: Polyhedron(ambient_dim=2, vertices=[], rays=[(2,2)], lines=[], base_ring=QQ)
A 1-dimensional polyhedron in QQ^2 defined as the convex hull of 1 vertex and 1 ray

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17339

    • Property Status changed from new to needs_review
    • Property Authors changed from to ​Darij Grinberg, Jonathan Kliem
    • Property Cc mkoeppe tscrim added
    • Property Branch changed from public/polytopes/0 to public/17339
    • Property Milestone changed from sage-6.4 to sage-9.0
    • Property Commit changed from f7642d6e2d2502e3df95c76ef2ffa7e9319a99aa to c5bf04100b1b1bbd32e7c85e0096f69934948811

  • Ticket #17339 – Description

    initial v15  
    1212
    1313{{{
    14 sage: Polyhedron(ambient_dim=2, vertices=[], rays=[(2,2)], lines=[], base_ring=QQ)
    15 A 1-dimensional polyhedron in QQ^2 defined as the convex hull of 1 vertex and 1 ray
    16 }}}
    17 This should be the empty polyhedron, since there are no vertices for the ray to emanate from.
    18 
    19 {{{
    2014sage: Polyhedron(ambient_dim=2, vertices=[], rays=[], lines=[], base_ring=QQ)
    2115The empty polyhedron in QQ^2
    2216}}}
    2317This is correct, but only because the code misunderstands the empty V-representation as no V-representation given at all.
    24 
    25 The attached branch fixes the H-representation part, but already that comes at the cost of failing doctests. The real deal is fixing the V-representation (which then should fix the doctests as well).