Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#17333 closed defect (fixed)

Update zeromq to 4.0.5

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords:
Cc: tscrim, vbraun Merged in:
Authors: Jean-Pierre Flori Reviewers: Volker Braun
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: 8fe27c2 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

The update itself is trivial. Upstream tarball at:

This also fixes a C++ linking issue:

and ensure that -no-undefined is passed to libtool to build a shared lib (or later on pyzmq will fail to build...) on Cygwin.

Change History (10)

comment:1 Changed 4 years ago by jpflori

  • Description modified (diff)

comment:2 Changed 4 years ago by jpflori

  • Description modified (diff)

comment:3 Changed 4 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/17333
  • Commit set to 8fe27c26d82e8fe7e467f59aa91783670d07f8b1
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Zeromq fails to build under Cygwin to Update zeromq to 4.0.5

New commits:

8fe27c2Update zeromq to 4.0.5 and let it compile on Cygwin.

comment:4 Changed 4 years ago by jpflori

  • Cc vbraun added
  • Description modified (diff)

comment:5 Changed 4 years ago by vbraun

  • Status changed from needs_review to positive_review

lgtm

comment:6 Changed 4 years ago by vbraun

  • Reviewers set to Volker Braun

comment:7 Changed 4 years ago by jpflori

FYI, I reported the -no-undefined thing upstream as https://github.com/zeromq/libzmq/issues/1263.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jpflori/ticket/17333 to 8fe27c26d82e8fe7e467f59aa91783670d07f8b1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 2 years ago by embray

  • Commit 8fe27c26d82e8fe7e467f59aa91783670d07f8b1 deleted
  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

comment:10 Changed 2 years ago by embray

  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

Nevermind, I think I misunderstood the status of this. Yes, the upstream issue was already fixed in https://github.com/zeromq/libzmq/pull/1283

Note: See TracTickets for help on using tickets.