#17326 closed enhancement (fixed)
Implementing subschemes functionality for projective "is_morphism"
Reported by:  jdefaria  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  algebraic geometry  Keywords:  
Cc:  Merged in:  
Authors:  Joao Alberto de Faria  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  f9ce9da (Commits)  Commit:  
Dependencies:  Stopgaps: 
Description
Changing the projective "is_morphism" to work over subschemes
Change History (15)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
 Branch set to u/jdefaria/ticket/17326
 Created changed from 11/12/14 18:57:43 to 11/12/14 18:57:43
 Modified changed from 11/12/14 18:59:16 to 11/12/14 18:59:16
comment:3 Changed 4 years ago by
 Commit set to 964c5248fe151a5b49b52ef3f46abb79470ca2bb
 Status changed from new to needs_review
comment:4 Changed 4 years ago by
 Reviewers set to Ben Hutz
 Status changed from needs_review to needs_work
You don't need this check since if it is a projective morphism it must be some kind of projective scheme.
if is_ProjectiveSpace(self.domain().ambient_space()) is False or is_ProjectiveSpace(self.codomain().ambient_space()) is False:
comment:5 Changed 4 years ago by
comment:6 Changed 4 years ago by
 Commit changed from 964c5248fe151a5b49b52ef3f46abb79470ca2bb to 58fa66da5aad406c5d72789b94042aeedb797279
Branch pushed to git repo; I updated commit sha1. New commits:
58fa66d  Rewrote main functionality, should work now

comment:7 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:8 Changed 4 years ago by
 Commit changed from 58fa66da5aad406c5d72789b94042aeedb797279 to 4adf3c9212ddeb60dc7649df33893bcb97bd95a6
Branch pushed to git repo; I updated commit sha1. New commits:
4adf3c9  17326 cleaned up cod, and fixed minor coerce issue

comment:9 Changed 4 years ago by
 Status changed from needs_review to needs_work
Sorry to be picky, but I'd like a subscheme example that fails to be a morphism on projective space, but which is a morphism for a subscheme, ie., the indeterminancy locus does not intersect the subscheme. The example you give is already a morphism on projective space.
Otherwise, this looks fine.
comment:10 Changed 4 years ago by
 Commit changed from 4adf3c9212ddeb60dc7649df33893bcb97bd95a6 to f9ce9da6f5cf2f9ae2a10b9339eaf1dc01bf3888
Branch pushed to git repo; I updated commit sha1. New commits:
f9ce9da  17326 Added example

comment:11 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:12 Changed 4 years ago by
 Status changed from needs_review to positive_review
ok, this looks good now.
comment:13 Changed 4 years ago by
 Type changed from defect to enhancement
comment:14 Changed 4 years ago by
 Branch changed from u/jdefaria/ticket/17326 to f9ce9da6f5cf2f9ae2a10b9339eaf1dc01bf3888
 Resolution set to fixed
 Status changed from positive_review to closed
comment:15 Changed 4 years ago by
 Commit f9ce9da6f5cf2f9ae2a10b9339eaf1dc01bf3888 deleted
 Milestone changed from sage6.4 to sage6.6
New commits:
Added functionality and example for subschemes