Opened 4 years ago

Closed 4 years ago

#17324 closed defect (fixed)

implement eq and ne for affine morphisms

Reported by: bhutz Owned by: bhutz
Priority: minor Milestone: sage-6.4
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Ben Hutz Reviewers: Joao Alberto de Faria
Report Upstream: N/A Work issues:
Branch: 218c56b (Commits) Commit: 218c56b05076cdd83cebff95afdfe0b38e2543c4
Dependencies: Stopgaps:

Description (last modified by bhutz)

Currently the following code fails because eq is inherited from somewhere else.

P.<x,y,z> = ProjectiveSpace(QQ,2)
f = H([x^2 - 2*x*y + z*x, z^2 -y^2 , 5*z*y])

Actually, it seems that eq and ne are not well done in projective_morphism either (the doc tests test the wrong functionality and it returns an error if the coordinates rings are different).

Change History (5)

comment:1 Changed 4 years ago by bhutz

  • Authors set to Ben Hutz
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from homogenize for affine morphisms needs to use projective embedding to implement eq and ne for affine morphisms

comment:2 Changed 4 years ago by bhutz

  • Branch set to u/bhutz/ticket/17324
  • Created changed from 11/12/14 18:13:06 to 11/12/14 18:13:06
  • Modified changed from 11/15/14 15:55:11 to 11/15/14 15:55:11

comment:3 Changed 4 years ago by jdefaria

  • Commit set to 218c56b05076cdd83cebff95afdfe0b38e2543c4
  • Status changed from needs_review to positive_review

Played around trying to break it, didn't run into any problems, passed doc test on my end as well, setting to positive review

New commits:

218c56b17324: fix eq and ne for affine and projective morphisms

comment:4 Changed 4 years ago by jdefaria

  • Reviewers set to Joao Alberto de Faria

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/bhutz/ticket/17324 to 218c56b05076cdd83cebff95afdfe0b38e2543c4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.