Opened 4 years ago

Closed 4 years ago

#17322 closed defect (fixed)

Readline 6.3 needs patching on Cygwin

Reported by: jpflori Owned by:
Priority: major Milestone: sage-6.4
Component: porting: Cygwin Keywords:
Cc: tscrim Merged in:
Authors: Jean-Pierre Flori Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e38497c (Commits) Commit: e38497c265fe8b0c05e7ed2620ed3ed6e1607a35
Dependencies: Stopgaps:

Description

Ones gets undefined references to sigsetjmp and similar functions. The following patch does the trick: ​https://github.com/Alexpux/MSYS2-packages/blob/master/readline/readline-6.3-cygwin.patch

Change History (5)

comment:1 Changed 4 years ago by tscrim

I've been meaning to report this...Will you make the branch Jean-Pierre, or do you want me to do so?

comment:2 Changed 4 years ago by jpflori

I'll do it, but please review it :)

comment:3 Changed 4 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to u/jpflori/ticket/17322
  • Commit set to e38497c265fe8b0c05e7ed2620ed3ed6e1607a35
  • Status changed from new to needs_review

New commits:

​e38497cLet readline 6.3 compile on Cywgin.

comment:4 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Builds on 32 and 64. Thanks.

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jpflori/ticket/17322 to e38497c265fe8b0c05e7ed2620ed3ed6e1607a35
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.