#17307 closed enhancement (fixed)
Minor fixes to developer manual
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | documentation | Keywords: | |
Cc: | Merged in: | ||
Authors: | Karl-Dieter Crisman | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | a9e9911 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Change History (10)
comment:1 Changed 8 years ago by
- Branch set to u/jdemeyer/ticket/17307
- Created changed from 11/08/14 10:41:06 to 11/08/14 10:41:06
- Modified changed from 11/08/14 10:41:06 to 11/08/14 10:41:06
comment:2 Changed 8 years ago by
- Commit set to a9e9911de8fe10c0927b43dd4891aa16fcf3b86f
- Status changed from new to needs_review
comment:3 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:4 follow-ups: ↓ 5 ↓ 7 Changed 8 years ago by
It would have been helpful to keep the commit in my name, I guess... but at any rate s-m only contributed the instructions for sws2rst, so I'm removing that. Thanks for the review.
comment:5 in reply to: ↑ 4 Changed 8 years ago by
Replying to kcrisman:
It would have been helpful to keep the commit in my name, I guess...
Honestly, I don't know how to do that...
comment:6 Changed 8 years ago by
- Commit changed from a9e9911de8fe10c0927b43dd4891aa16fcf3b86f to 7fa0de34aa713520d0fef2a7065581599dfd7bf3
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
7fa0de3 | More reorganization of developer guide
|
comment:7 in reply to: ↑ 4 Changed 8 years ago by
Replying to kcrisman:
It would have been helpful to keep the commit in my name
Done using
git commit --amend --author "Karl-Dieter Crisman"
comment:8 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:9 Changed 8 years ago by
- Branch changed from u/jdemeyer/ticket/17307 to 7fa0de34aa713520d0fef2a7065581599dfd7bf3
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 7 years ago by
- Branch changed from 7fa0de34aa713520d0fef2a7065581599dfd7bf3 to a9e9911de8fe10c0927b43dd4891aa16fcf3b86f
- Commit 7fa0de34aa713520d0fef2a7065581599dfd7bf3 deleted
The last commit has not been merged, see the discussion at sage-devel. The last commit was "only" the change of the author of the commit, so I do not open a new ticket.
New commits:
More reorganization of developer guide