Opened 13 years ago

Closed 13 years ago

#1729 closed defect (fixed)

[with patch, positive review] disable password prompt on initial startup

Reported by: robertwb Owned by: robertwb
Priority: critical Milestone: sage-2.10
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Because the user can always do notebook(reset=True) it isn't a security risk to automatically log you in the web page that pops up.

This patch fixes this issue.

Attachments (3)

1729-notebook-login.patch​ (6.9 KB) - added by robertwb 13 years ago.
1729-notebook-login.2.patch​ (6.9 KB) - added by boothby 13 years ago.
inotebook-fix.patch​ (860 bytes) - added by robertwb 13 years ago.

Download all attachments as: .zip

Change History (11)

Changed 13 years ago by robertwb

comment:1 Changed 13 years ago by was

There is no patch attacheD?!

comment:2 Changed 13 years ago by robertwb

Sorry, took me more than 18 seconds to attach the patch.

comment:3 Changed 13 years ago by robertwb

  • Summary changed from disable password prompt on initial startup to [with patch] disable password prompt on initial startup

Changed 13 years ago by boothby

comment:4 Changed 13 years ago by boothby

  • Summary changed from [with patch] disable password prompt on initial startup to [with patch, positive review] disable password prompt on initial startup

Robert's patch works for me, but adds noise to the log. Revised patch removes the noise.

comment:5 Changed 13 years ago by was

  • Summary changed from [with patch, positive review] disable password prompt on initial startup to [with patch, negative review] disable password prompt on initial startup

sage: notebook(secure=False) is now broken.

Changed 13 years ago by robertwb

comment:6 Changed 13 years ago by robertwb

  • Owner changed from boothby to robertwb
  • Status changed from new to assigned
  • Summary changed from [with patch, negative review] disable password prompt on initial startup to [with patch] disable password prompt on initial startup

comment:7 Changed 13 years ago by was

  • Summary changed from [with patch] disable password prompt on initial startup to [with patch, positive review] disable password prompt on initial startup

comment:8 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.alpha1. Specifically I merged

  • 1729-notebook-login.2.patch
  • inotebook-fix.patch

Cheers,

Michael

Note: See TracTickets for help on using tickets.