Opened 15 years ago
Closed 15 years ago
#1729 closed defect (fixed)
[with patch, positive review] disable password prompt on initial startup
| Reported by: | robertwb | Owned by: | robertwb |
|---|---|---|---|
| Priority: | critical | Milestone: | sage-2.10 |
| Component: | notebook | Keywords: | |
| Cc: | Merged in: | ||
| Authors: | Reviewers: | ||
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description
Because the user can always do notebook(reset=True) it isn't a security risk to automatically log you in the web page that pops up.
This patch fixes this issue.
Attachments (3)
Change History (11)
Changed 15 years ago by
| Attachment: | 1729-notebook-login.patch added |
|---|
comment:1 Changed 15 years ago by
comment:3 Changed 15 years ago by
| Summary: | disable password prompt on initial startup → [with patch] disable password prompt on initial startup |
|---|
Changed 15 years ago by
| Attachment: | 1729-notebook-login.2.patch added |
|---|
comment:4 Changed 15 years ago by
| Summary: | [with patch] disable password prompt on initial startup → [with patch, positive review] disable password prompt on initial startup |
|---|
Robert's patch works for me, but adds noise to the log. Revised patch removes the noise.
comment:5 Changed 15 years ago by
| Summary: | [with patch, positive review] disable password prompt on initial startup → [with patch, negative review] disable password prompt on initial startup |
|---|
sage: notebook(secure=False) is now broken.
Changed 15 years ago by
| Attachment: | inotebook-fix.patch added |
|---|
comment:6 Changed 15 years ago by
| Owner: | changed from boothby to robertwb |
|---|---|
| Status: | new → assigned |
| Summary: | [with patch, negative review] disable password prompt on initial startup → [with patch] disable password prompt on initial startup |
comment:7 Changed 15 years ago by
| Summary: | [with patch] disable password prompt on initial startup → [with patch, positive review] disable password prompt on initial startup |
|---|
comment:8 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Merged in Sage 2.10.alpha1. Specifically I merged
- 1729-notebook-login.2.patch
- inotebook-fix.patch
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
There is no patch attacheD?!