Opened 5 years ago

Closed 5 years ago

#17262 closed enhancement (fixed)

Update to gcc 4.9.2

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: fbissey, jpflori Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 548b826 (Commits) Commit: 548b8261f3219f3951bcb59523b76698d7e00bba
Dependencies: Stopgaps:

Change History (24)

comment:1 Changed 5 years ago by vbraun

  • Authors set to Volker Braun
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 5 years ago by vbraun

  • Branch set to u/vbraun/update_to_gcc_4_9_2

comment:3 Changed 5 years ago by vbraun

  • Cc fbissey jpflori added
  • Commit set to 8fb0c311341d40553c0d0f14c2d89d1f7e928e32
  • Status changed from new to needs_review

New commits:

0087e6fBump version number
8fb0c31Remove patch that is now in upsteam

comment:4 follow-up: Changed 5 years ago by jhpalmieri

On two OS X systems (one 10.9, one 10.10) this builds successfully but takes longer to build than previous gcc's. Is that the nature of version 4.9, or are we building extra stuff?

The time difference: on an old slow machine, it took 58 minutes to build 4.7.3 and 101 minutes to build this. On a newer faster machine, it took 16 minutes to build 4.7.3 and 21 minutes to build this. This time increase was also true with version 4.9.1. Do you see this on other platforms?

comment:5 Changed 5 years ago by vbraun

Sounds about right. Also includes the C -> C++ switch and C++ is definitely slower to compile since it is a much richer language.

comment:6 Changed 5 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:7 in reply to: ↑ 4 Changed 5 years ago by fbissey

Replying to jhpalmieri:

On two OS X systems (one 10.9, one 10.10) this builds successfully but takes longer to build than previous gcc's. Is that the nature of version 4.9, or are we building extra stuff?

The time difference: on an old slow machine, it took 58 minutes to build 4.7.3 and 101 minutes to build this. On a newer faster machine, it took 16 minutes to build 4.7.3 and 21 minutes to build this. This time increase was also true with version 4.9.1. Do you see this on other platforms?

Apart from the switch to c++ you may also be building a few more things compared to 4.7.3. Useful things like the sanitizer, more conformance to C++11, some C++14, support for latest openmp specification. All those take a bit of time.

comment:8 Changed 5 years ago by jdemeyer

  • Branch changed from u/vbraun/update_to_gcc_4_9_2 to u/jdemeyer/ticket/17262
  • Created changed from 10/30/14 15:27:25 to 10/30/14 15:27:25
  • Modified changed from 10/31/14 08:48:03 to 10/31/14 08:48:03

comment:9 Changed 5 years ago by jdemeyer

  • Commit changed from 8fb0c311341d40553c0d0f14c2d89d1f7e928e32 to 419f5ae5280eb124e56af80bee8328eb64f9cdc5
  • Status changed from needs_review to positive_review

New commits:

419f5aeRemove work-around for GCC bug fixed in GCC 4.9.0

comment:10 Changed 5 years ago by vbraun

Some of the failure logs people posted on sage-devel were due to homebrew's isl in /usr/local, which is apparently good enough to be detected but not good enough to compile gcc. I think we should just disable isl/cloog/graphite on Darwin, its unlikely that anybody will have working libraries to build graphite... thoughts?

comment:11 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17262 to u/vbraun/ticket/17262

comment:12 Changed 5 years ago by vbraun

  • Commit changed from 419f5ae5280eb124e56af80bee8328eb64f9cdc5 to 68a9d557a5ad6b68e5f1ac559faf4ecb6bf76d3b
  • Status changed from positive_review to needs_review

New commits:

68a9d55Disable isl/cloog on Darwin

comment:13 Changed 5 years ago by vbraun

Also, gcc 4.6.3 in Ubuntu 12.04 doesn't work: https://groups.google.com/d/msg/sage-release/xgmJ3nAcUOY/jH8OZjftYRsJ

Since we already shitlisted 4.6.1 and 4.6.2, how about we build gcc for all 4.6.x versions?

comment:14 Changed 5 years ago by git

  • Commit changed from 68a9d557a5ad6b68e5f1ac559faf4ecb6bf76d3b to 44ad8d2882ae7605a1477de3cdc95f0b71560e6d

Branch pushed to git repo; I updated commit sha1. New commits:

44ad8d2Never use gcc-4.6.* if found on the system

comment:15 Changed 5 years ago by vbraun

Done!

comment:16 Changed 5 years ago by jdemeyer

Instead of blacklisting GCC 4.6 specifically, would it not make more sense to simply declare all GCC versions <= 4.6 as "old"?

comment:17 Changed 5 years ago by vbraun

I thought about it, but then nobody complained about it. It might actually work ;-)

comment:18 Changed 5 years ago by dimpase

  • Status changed from needs_review to needs_work

this fi;; should go!

diff --git a/build/install b/build/install
index a5fae62..abe04d7 100755
--- a/build/install
+++ b/build/install
@@ -147,7 +147,6 @@ else
                 echo >&2 "Installing GCC because you have $CXX version $GCCVERSION."
                 echo >&2 "gcc-4.6.* has known bugs affecting Sage."
                 need_to_install_gcc=yes;;
-                fi;;
             4.7.0)
                 # GCC 4.7.0 is very broken on ia64, see
                 # http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48496

comment:19 Changed 5 years ago by git

  • Commit changed from 44ad8d2882ae7605a1477de3cdc95f0b71560e6d to 548b8261f3219f3951bcb59523b76698d7e00bba

Branch pushed to git repo; I updated commit sha1. New commits:

548b826Remove stray line

comment:20 Changed 5 years ago by vbraun

Oops, fixed!

comment:21 Changed 5 years ago by dimpase

  • Status changed from needs_work to needs_info

anything else not done here? Can it be reviewed?

comment:22 Changed 5 years ago by vbraun

  • Status changed from needs_info to needs_review

As far as I'm concerned its good to go. Positive review to Jeroen's commits...

Last edited 5 years ago by vbraun (previous) (diff)

comment:23 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:24 Changed 5 years ago by vbraun

  • Branch changed from u/vbraun/ticket/17262 to 548b8261f3219f3951bcb59523b76698d7e00bba
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.