Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17257 closed defect (fixed)

GCD_list should return zero for an empty list

Reported by: slelievre Owned by:
Priority: major Milestone: sage-6.4
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Samuel Lelièvre Reviewers: Vincent Delecroix, Peter Bruin
Report Upstream: N/A Work issues:
Branch: b7a04f7 (Commits) Commit:
Dependencies: Stopgaps:

Description

The function GCD_list from sage.rings.integer returns one instead of zero for an empty list.

Change History (9)

comment:1 Changed 5 years ago by slelievre

  • Branch set to u/slelievre/17257_GCD_list
  • Commit set to c36e45325b1d27b1f254b6583c10a974c359cf35
  • Status changed from new to needs_review

New commits:

c36e453trac #17257: fix GCD_list

comment:2 follow-up: Changed 5 years ago by vdelecroix

  • Branch changed from u/slelievre/17257_GCD_list to public/17257
  • Commit changed from c36e45325b1d27b1f254b6583c10a974c359cf35 to 94a9e48623d1bc62c655859944f2e3807b4473b1
  • Reviewers set to Vincent Delecroix

Hello,

I added a commit on top of yours. If you like it you can set to positive review.

Vincent


New commits:

94a9e48trac #17257: improve documentation

comment:3 Changed 5 years ago by git

  • Commit changed from 94a9e48623d1bc62c655859944f2e3807b4473b1 to 2a2a3c555bee6f3f59f06ddb4c5d6429d97211fa

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2a2a3c5trac #17257: improve documentation

comment:4 Changed 5 years ago by git

  • Commit changed from 2a2a3c555bee6f3f59f06ddb4c5d6429d97211fa to 4f8b380be1fab119dce9df1053e236dffe917a5d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4f8b380trac #17257: improve documentation

comment:5 Changed 5 years ago by git

  • Commit changed from 4f8b380be1fab119dce9df1053e236dffe917a5d to b7a04f7d4a315d1faeda521eefb35af729214882

Branch pushed to git repo; I updated commit sha1. New commits:

b7a04f7Trac 17257: more documentation improvements

comment:6 in reply to: ↑ 2 Changed 5 years ago by pbruin

  • Reviewers changed from Vincent Delecroix to Vincent Delecroix, Peter Bruin

Replying to vdelecroix:

I added a commit on top of yours. If you like it you can set to positive review.

Same for me.

comment:7 Changed 5 years ago by slelievre

  • Status changed from needs_review to positive_review

Thanks for the improvements to the documentation. Positive review.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from public/17257 to b7a04f7d4a315d1faeda521eefb35af729214882
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 5 years ago by slelievre

  • Commit b7a04f7d4a315d1faeda521eefb35af729214882 deleted

For reference, the gcd of an empty list is discussed in this sage-devel thread.

Note: See TracTickets for help on using tickets.