Upgrade to Singular-4-0-1

[jdemeyer]

Lots of stuff has changed in Singular 4. But now the attached branch is almost working.

Repackaged upstream tarball: ​http://boxen.math.washington.edu/home/jdemeyer/spkg/singular-4.0.1p1.tar.bz2

[jpflori]

Yeah, the update is non trivial, that's a reason to get #17184 (and so #16882) inbetween.

[jdemeyer]

Replying to jpflori:

Yeah, the update is non trivial

I wonder if we even have a Sage developer who is familiar enough with Singular to do this (for the record: not me, I know nothing about Singular).

that's a reason to get #17184 (and so #16882) inbetween.

Of course, I'm not arguing with that.

[jpflori]

Replying to jdemeyer:

Replying to jpflori:

Yeah, the update is non trivial

I wonder if we even have a Sage developer who is familiar enough with Singular to do this (for the record: not me, I know nothing about Singular).

Maybe Burcin would do... IIRC the update was proposed as a GSoC project.

[jakobkroeker]

Q: where to get the singular tarball for this commit? I get a failure at

Trying to download http://www.sagemath.org/packages/upstream/singular/singular-4.0.1p1.tar.bz2

2.

Update to Singular 4.0.1

Maybe Burcin would do...

Could the update to 4.0.1. be done by at least two or three persons to spread the knownledge about Singular internals?

[jpflori]

You have to put a tarball repackaged by the spkg-src script in the upstream folder directly. Once the ticket is merged, the tarball will be put on the official mirror and could be downloaded automatically but not at the moment.

I've put a repackaged tarball at:

• ​http://boxen.math.washington.edu/home/jpflori/upstream/singular-4.0.1.tar.bz2

[jpflori]

(I'm not sure the checksums will the same as what Jeroen branch expect, run ./sage -sh sage-fix-pkg-checksums after you have downloaded the tarball to fix this.)

[jpflori]

And I'd be happy to work on the upgrade and learn more about Singular's internals, but please also review the "easy" #17184 (where I've already learnt some stuff) firsT.

[jakobkroeker]

Singular 4.0.1. compiles now in sage but sage does not yet - I just pushed a branch 'u/jakobkroeker/ticket/17254'. You have to correct the 'singular-4.0.1p1.tar.bz2' tarball to get it work ( the 'm4' folder is missing).

For the moment I removed some patches; we probably will have to adjust them later on. For example there is meanwhile no such thing like 'lomalloc_ndebug' so if we want to disable some debug functionality or output for omalloc we have to do that by passing appropriate flags to omalloc/configure, e,g '--enable-optimizationflags --disable-debug --without-debug' ?

Also I disabled the currently broken '--enable-debugoutput' configure flag for the standalone 'factory' and informed Oleksander Motsak about the issue.

Could someone of you take care of the sage compile errors and figure out what is going wrong and/or ask for help in the Singular forum? I can't do that easily, because within the Singular-team I'm out-of-favor because I constantly criticise their software and thus I will likely get little or no support.

Jakob

[jdemeyer]

New commits:

​4c0bba3

singular 4.0.1 builds now, but sage does not due to changes in libsingular?

[jakobkroeker]

first hint: for example the interface of 'naIsZero' seems changed from

BOOLEAN naIsZero(number a)

to

BOOLEAN naIsZero(number a, const coeffs cf)

Persons who might have an idea about the changes:

Oleksandr Motsak Mohamed Barakat Martin Lee Hans Schönemann

see contact details at ​http://www.mathematik.uni-kl.de/agag/mitglieder/

[jdemeyer]

Replying to jpflori:

I've put a repackaged tarball at:

• ​http://boxen.math.washington.edu/home/jpflori/upstream/singular-4.0.1.tar.bz2

That's an older version than the one that I put in the ticket description, any reason...?

[jdemeyer]

Replying to jakobkroeker:

You have to correct the 'singular-4.0.1p1.tar.bz2' tarball to get it work ( the 'm4' folder is missing).

My tarball compiled fine, so what is the problem?

[jdemeyer]

You should never run ./autogen.sh, that is supposed to be run at packaging-time, not build-time.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​79c079f	Upgrade to Singular-4-0-1
​4c0bba3	singular 4.0.1 builds now, but sage does not due to changes in libsingular?
​80a6b05	Merge commit '4c0bba3' into ticket/17254

[jakobkroeker]

My tarball compiled fine, so what is the problem?

Confirm; cannot reproduce the issue. So likely I didn't use the recent tarball, or I screwed something up.

You should never run ./autogen.sh, that is supposed to be run at packaging-time, not build-time.

I'm guilty ;-)

[jakobkroeker]

singulars spkg-install:

the '--enable-debugoutput' configure flag for standalone factory needs now in additon '--enable-streamio --without-Singular'

[jakobkroeker]

After a little more tweaking and temporarily disabling the extension fields/rings, I was able to build some parts of sage with Singular 4.0.1 on a 'fc18 system' and then.. sage crashes at start! That happens because I didn't update ring creation right - I only recently discovered examples at './libpolys/tests/rings_test.h'. And some sage packages create common rings at loading time.

remaining riddles:

• during build one sage file tried to link to -lsingular (I have no idea why), instead to the libSingular* files (that changed!), so I worked around by manually creating links to libSingular* files.

• on a ScientificLinux? system I get errors like "ImportError?: /home/kroeker/Projects/sage-singular-4.0.1/local/lib/python2.7/site-packages/sage/rings/polynomial/plural.so: undefined symbol: wFunctionalBuch". This symbol is in libSingular*

• fix ring creation. See examples at './libpolys/tests/rings_test.h'

• the extension fields will need some more love. See 'algext.h' and 'transext.h'. @Martin: could you take a look?

• some mapping functions (e.g. nr2mMapZp) now require a source and dst (coefficient) parameter. Not sure if I did it right (source: currentRing, dest: _ring or vice versa?)

• I didn't fix unused interface definitions in singular-cdefs.pxi. TODO

See branch u/jakobkroeker/ticket/17254 and some notes at ​https://github.com/jakobkroeker/jk_test_sage/issues/13

If a build get stuck before errors described above, then maybe a 'make distclean' is necessary. And of course, the Singular tarball ​http://boxen.math.washington.edu/home/jdemeyer/spkg/singular-4.0.1p1.tar.bz2 is required.

Any help appreciated.

---

New commits:

​79c079f	Upgrade to Singular-4-0-1
​2fcaeb5	Update Singular to 4.0.1
​4c0bba3	singular 4.0.1 builds now, but sage does not due to changes in libsingular?
​80a6b05	Merge commit '4c0bba3' into ticket/17254
​2ae243a	messy fixes
​ff2a9dc	required changes for singular to build sage; should be fixed upstream
​3b7877e	hacking sage to build with Singular 4.0.1. needs more love for extension coefficient fields and a refactoring
​f178dfc	fixing nr2mMapZp call

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​8ba17d8

messy fixes

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​2ae243a	messy fixes
​ff2a9dc	required changes for singular to build sage; should be fixed upstream
​3b7877e	hacking sage to build with Singular 4.0.1. needs more love for extension coefficient fields and a refactoring
​f178dfc	fixing nr2mMapZp call
​8e82387	Merge branch 'u/jakobkroeker/jakobkroeker.ticket.17254' of git://trac.sagemath.org/sage into jakobkroeker.ticket.17254
​c2a21bd	fixed some ring creation

[jakobkroeker]

New commits:

​6384b9b

Upgrade to Singular 4.0.1: incomplete, messy patch(first aproach)