Opened 6 years ago
Closed 6 years ago
#17253 closed defect (fixed)
Bug in explain_construction for Brouwer-van Rees
| Reported by: | ncohen | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-6.4 |
| Component: | combinatorial designs | Keywords: | |
| Cc: | vdelecroix | Merged in: | |
| Authors: | Nathann Cohen | Reviewers: | Vincent Delecroix |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 14df527 (Commits, GitHub, GitLab) | Commit: | 14df52750e6327301b5cbb51f38a1ac5d070fd4d |
| Dependencies: | #16922 | Stopgaps: |
Status badges
Description (last modified by )
Easy:
sage: print designs.orthogonal_arrays.explain_construction(9,834) TypeError: brouwer_van_rees_with_one_truncated_column() got an unexpected keyword argument 'explain_construction'
That can be solved by removing the build function brouwer_van_rees_with_one_truncated_column that we do not need anymore, and calling wilson_construction directly. The branch also fixes a bug in wilson_construction when OA=None, i.e. only the non-Brouwer case was handled.
Nathann
Change History (6)
comment:1 Changed 6 years ago by
- Branch set to u/ncohen/17253
- Dependencies set to #16922
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Commit set to c15152f8d1170af36e5929380ac1a41f1ae20148
comment:3 Changed 6 years ago by
- Description modified (diff)
comment:4 Changed 6 years ago by
- Branch changed from u/ncohen/17253 to public/17253
- Commit changed from c15152f8d1170af36e5929380ac1a41f1ae20148 to 14df52750e6327301b5cbb51f38a1ac5d070fd4d
- Reviewers set to Vincent Delecroix
Rebased over 6.4.rc0. Everything works!
Vincent
New commits:
| 14df527 | trac #17253: Bug in explain_construction for Brouwer-van Rees
|
comment:5 Changed 6 years ago by
- Status changed from needs_review to positive_review
comment:6 Changed 6 years ago by
- Branch changed from public/17253 to 14df52750e6327301b5cbb51f38a1ac5d070fd4d
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
trac #16559: A description for the Brouwer-van Rees constructiontrac #16920: New V(m,t) vectorstrac #16920: Make the V(m,t) database more compacttrac #16920: Even more MOLStrac #16920: Correct bibliographical referencestrac #16920: Merged with updated #16559trac #16922: find_brouwer_van_rees_with_one_truncated_columntrac #16922: big optim. + small optim. + doctesttrac #16922: rewrite multiple (new name int_as_sum)trac #17253: Bug in explain_construction for Brouwer-van Rees