Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#17247 closed enhancement (fixed)

Add a polytope tutorial

Reported by: kcrisman Owned by:
Priority: minor Milestone: sage-6.4
Component: geometry Keywords: thematic tutorials
Cc: Merged in:
Authors: sarah-marie belcastro, Karl-Dieter Crisman Reviewers: Karl-Dieter Crisman, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3124458 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

A Sage user has been kind enough to write a polytopes tutorial. Here it is!

Change History (26)

comment:1 Changed 8 years ago by kcrisman

  • Branch set to u/kcrisman/polytopetut
  • Commit set to 8fcca03cd708d025e0672152a1da63da7c6f5ada
  • Status changed from new to needs_review

This is a first-time contributor, so in this case any suggestions about formatting etc. would be best handled by just continuing the branch.


New commits:

f3c5c3dAdded polytopes tutorial to thematic tutorials
8fcca03Added polytope tutorial to list of tutorials

comment:2 Changed 8 years ago by kcrisman

Also, I didn't do a lot of editing here, but did remove references to images since they were standard plots, so there may be some Sphinx issues - but I hope not.

comment:3 Changed 8 years ago by git

  • Commit changed from 8fcca03cd708d025e0672152a1da63da7c6f5ada to 223590a769b8f023bcb5254603c335be4f1c5fc6

Branch pushed to git repo; I updated commit sha1. New commits:

223590apartial fix to sphinx issue

comment:4 Changed 8 years ago by kcrisman

There are still some very minor Sphinx things about a link and the toc tree but I think a review is still in order, as they can be dealt with after content.

comment:5 Changed 8 years ago by git

  • Commit changed from 223590a769b8f023bcb5254603c335be4f1c5fc6 to f739a3b4211bb9e574eeb89b8e1aae52ca66ba92

Branch pushed to git repo; I updated commit sha1. New commits:

f739a3bMake polytope tutorial doc build correctly

comment:6 Changed 8 years ago by kcrisman

  • Authors changed from sarah-marie belcastro to sarah-marie belcastro, Karl-Dieter Crisman
  • Keywords thematic tutorials added

Okay, now this is 100% ready for review!

comment:7 follow-up: Changed 8 years ago by chapoton

Could you please use the new style of doctest continuation, namely ....: instead of ... ?

comment:8 in reply to: ↑ 7 Changed 8 years ago by kcrisman

Could you please use the new style of doctest continuation, namely ....: instead of ... ?

Ah, this is just what came out of sws2rst, I don't think I was more than dimly aware of that.

Why don't you take a look at the rest of the content or whatever (pass doctests?) and once you have all things to fix, I'll do them all at once.

comment:9 Changed 8 years ago by chapoton

  • Branch changed from u/kcrisman/polytopetut to public/ticket/17247
  • Commit changed from f739a3b4211bb9e574eeb89b8e1aae52ca66ba92 to 8a089aa7208c273d322428b01391bcb00d606ccb
  • Status changed from needs_review to needs_work

Hello,

I made a reviewer commit. There remains a problem with the schlegel projection (near then end) which is deprecated. This needs to be changed.


New commits:

300e90eMerge branch 'u/kcrisman/polytopetut' of trac.sagemath.org:sage into 17247
8a089aatrac #17247 reviewer commit

comment:10 Changed 8 years ago by kcrisman

Thanks for the review, very helpful.

As it happens, the author actually always spells her name without capital letters, so I'll change that when I get around to fixing the Schlegel piece - I think it's the show() that is deprecated, not the projection. In fact, this was apparently not doctested at #16625

+    def show(self, *args, **kwds):
+        from sage.misc.superseded import deprecation
+        deprecation(16625, 'use Projection.plot instead')
+        return self.plot(*args, **kwds)

so I may need to fix that as well for this ticket.

comment:11 Changed 8 years ago by git

  • Commit changed from 8a089aa7208c273d322428b01391bcb00d606ccb to f633d825b67cbd4306bbfc2ecbc0207f83c096a0

Branch pushed to git repo; I updated commit sha1. New commits:

f633d82Fix schlegel plot show

comment:12 Changed 8 years ago by kcrisman

Okay, this commit should take care of the docs; I assume they look fine built, no other missing double colons or something? Thanks for catching the LaTeX things!

I will do one more commit to add the doctest that should have been added before.

comment:13 Changed 8 years ago by git

  • Commit changed from f633d825b67cbd4306bbfc2ecbc0207f83c096a0 to 3124458e4b0c196759cae53f8705b72ec1c6afa9

Branch pushed to git repo; I updated commit sha1. New commits:

3124458Add doctest for the deprecation of Projection.show

comment:14 Changed 8 years ago by kcrisman

  • Status changed from needs_work to needs_review

Okay, hopefully it's good this time.

comment:15 Changed 8 years ago by kcrisman

  • Reviewers changed from Karl-Dieter Crisman to Karl-Dieter Crisman, Frédéric Chapoton

comment:16 Changed 8 years ago by chapoton

  • Status changed from needs_review to positive_review

Ok, looks good to me.

comment:17 follow-up: Changed 8 years ago by vbraun

  • Authors changed from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

I'm capitalizing the author's name, let me know if your real name uses the lower-case spelling...

comment:18 Changed 8 years ago by vbraun

  • Branch changed from public/ticket/17247 to 3124458e4b0c196759cae53f8705b72ec1c6afa9
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:19 in reply to: ↑ 17 Changed 8 years ago by kcrisman

  • Authors changed from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman
  • Commit 3124458e4b0c196759cae53f8705b72ec1c6afa9 deleted

I'm capitalizing the author's name, let me know if your real name uses the lower-case spelling...

Yes, hers definitely does!

Last edited 8 years ago by kcrisman (previous) (diff)

comment:20 Changed 8 years ago by jdemeyer

  • Authors changed from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

comment:21 Changed 8 years ago by kcrisman

  • Authors changed from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman

Doggone it, I had to change that back once already.

comment:22 Changed 8 years ago by jdemeyer

Sorry, I assumed it was a mistake.

comment:23 Changed 8 years ago by kcrisman

Yup, understood.

comment:24 Changed 6 years ago by chapoton

  • Authors changed from sarah-marie belcastro, Karl-Dieter Crisman to Sarah-Marie Belcastro, Karl-Dieter Crisman

comment:25 Changed 6 years ago by kcrisman

  • Authors changed from Sarah-Marie Belcastro, Karl-Dieter Crisman to sarah-marie belcastro, Karl-Dieter Crisman

Please read comment:19, comment:21 and comment:22

Last edited 6 years ago by kcrisman (previous) (diff)

comment:26 Changed 6 years ago by chapoton

oh, shoot. Sorry. I was cleaning our list of authors..

Note: See TracTickets for help on using tickets.