Opened 6 years ago
Closed 6 years ago
#17224 closed defect (fixed)
Fix pickling of NC rings with weighted term order
Reported by: | tscrim | Owned by: | tscrim |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | pickling | Keywords: | |
Cc: | mmarco, jhpalmieri | Merged in: | |
Authors: | Travis Scrimshaw | Reviewers: | Miguel Marco |
Report Upstream: | N/A | Work issues: | |
Branch: | 13a552e (Commits, GitHub, GitLab) | Commit: | 13a552e4bc9fca71db81f6d2bd1a766f8d782e8f |
Dependencies: | Stopgaps: |
Description (last modified by )
The term order is pickled by the name rather than the object TermOrder
. This causes problems for term orders which need additional arguments.
sage: from sage.rings.polynomial.term_order import TermOrder sage: F.<x,y> = FreeAlgebra(QQ) sage: g = F.g_algebra({y*x:-x*y}, order=TermOrder('wdegrevlex', [1,2])) sage: loads(dumps(g)) # Boom
Change History (3)
comment:1 Changed 6 years ago by
- Branch set to public/pickling/term_order_NC_plural-17224
- Cc mmarco jhpalmieri added
- Commit set to 13a552e4bc9fca71db81f6d2bd1a766f8d782e8f
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Reviewers set to Miguel Marco
- Status changed from needs_review to positive_review
Looks good
comment:3 Changed 6 years ago by
- Branch changed from public/pickling/term_order_NC_plural-17224 to 13a552e4bc9fca71db81f6d2bd1a766f8d782e8f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
1 hour of my life for 2 lines... Needs review.
New commits:
Fix for pickling NC rings with weighted term order.