Opened 13 years ago

Closed 13 years ago

#1722 closed enhancement (fixed)

[with patch, with positive review] Symbolic Matrices should be callable.

Reported by: boothby Owned by: mhansen
Priority: major Milestone: sage-2.10.3
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Matrices of symbolic objects should either be callable, or support substitution, per user request at conference.

Attachments (1)

1722.patch (9.3 KB) - added by mhansen 13 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 13 years ago by mabshoff

  • Milestone set to sage-2.10

comment:2 Changed 13 years ago by mhansen

  • Owner changed from was to mhansen
  • Status changed from new to assigned

comment:3 Changed 13 years ago by mhansen

  • Summary changed from Symbolic Matrices should be callable. to [with patch, needs review] Symbolic Matrices should be callable.

comment:4 Changed 13 years ago by ncalexan

  • Summary changed from [with patch, needs review] Symbolic Matrices should be callable. to [with patch, with positive review] Symbolic Matrices should be callable.

Great doctests, good comments, looks good to me. I say apply.

comment:5 Changed 13 years ago by mabshoff

Against my 2.10.2.alpha0 I get a reject:

patch -p1 --dry-run < trac_1722.patch
patching file sage/matrix/matrix_symbolic_dense.pxd
patching file sage/matrix/matrix_symbolic_dense.pyx
Hunk #1 succeeded at 15 with fuzz 2 (offset 9 lines).
Hunk #2 succeeded at 48 with fuzz 2 (offset 8 lines).
Hunk #3 succeeded at 536 (offset 248 lines).
Hunk #4 FAILED at 617.
Hunk #5 FAILED at 681.
2 out of 5 hunks FAILED -- saving rejects to file sage/matrix/matrix_symbolic_dense.pyx.rej

The patch should be rebased against 2.10.2.alpha0 once it is out.

Cheers,

Michael

comment:6 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, with positive review] Symbolic Matrices should be callable. to [with patch, with positive review, needs rebase] Symbolic Matrices should be callable.

Changed 13 years ago by mhansen

comment:7 Changed 13 years ago by mhansen

  • Summary changed from [with patch, with positive review, needs rebase] Symbolic Matrices should be callable. to [with patch, with positive review] Symbolic Matrices should be callable.

New rebased patch attached.

comment:8 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 2.10.3.rc0

Note: See TracTickets for help on using tickets.