Opened 7 years ago

Closed 7 years ago

#17199 closed enhancement (fixed)

doc cleanup in multi_polynomial_ideal

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-6.4
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1a7465f (Commits, GitHub, GitLab) Commit: 1a7465fef0742d7de7ec86c5041df61199345270
Dependencies: Stopgaps:

Status badges

Description

fixing a few glitches in src/sage/rings/polynomial/multi_polynomial_ideal.py

Change History (8)

comment:1 Changed 7 years ago by chapoton

  • Branch set to u/chapoton/17199
  • Commit set to 96a07b08bc45dd63e39b64d19589e98dfc6aa06b
  • Status changed from new to needs_review

New commits:

96a07b0trac #17xxx little cleanup in multi_polynomial_ideal

comment:2 Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Two minor things: could you latex the base rings in the note about criterion, and correctly indent those two loops that you changed the ...? (If either of those don't make sense, I can do it tonight.) Once done, you can set a positive reviewon my behalf.

comment:3 Changed 7 years ago by git

  • Commit changed from 96a07b08bc45dd63e39b64d19589e98dfc6aa06b to 7d5371b50a61ae80ade8129f0045f69848af4966

Branch pushed to git repo; I updated commit sha1. New commits:

7d5371btrac #17199 reviewer's comments

comment:4 Changed 7 years ago by git

  • Commit changed from 7d5371b50a61ae80ade8129f0045f69848af4966 to 1a7465fef0742d7de7ec86c5041df61199345270

Branch pushed to git repo; I updated commit sha1. New commits:

1a7465ftrac #17199 a few more little typos

comment:5 Changed 7 years ago by chapoton

Ok, I have done that, plus a few other minor things. The result is not perfect, but better than before.

comment:6 Changed 7 years ago by chapoton

Travis ? Could you please have a look ?

comment:7 Changed 7 years ago by tscrim

  • Status changed from needs_review to positive_review

Ah sorry. LGTM.

comment:8 Changed 7 years ago by vbraun

  • Branch changed from u/chapoton/17199 to 1a7465fef0742d7de7ec86c5041df61199345270
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.