Opened 8 years ago
Closed 8 years ago
#17199 closed enhancement (fixed)
doc cleanup in multi_polynomial_ideal
Reported by:  Frédéric Chapoton  Owned by:  

Priority:  minor  Milestone:  sage6.4 
Component:  commutative algebra  Keywords:  
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  1a7465f (Commits, GitHub, GitLab)  Commit:  1a7465fef0742d7de7ec86c5041df61199345270 
Dependencies:  Stopgaps: 
Description
fixing a few glitches in src/sage/rings/polynomial/multi_polynomial_ideal.py
Change History (8)
comment:1 Changed 8 years ago by
Branch:  → u/chapoton/17199 

Commit:  → 96a07b08bc45dd63e39b64d19589e98dfc6aa06b 
Status:  new → needs_review 
comment:2 Changed 8 years ago by
Reviewers:  → Travis Scrimshaw 

Two minor things: could you latex the base rings in the note about criterion, and correctly indent those two loops that you changed the ...
? (If either of those don't make sense, I can do it tonight.) Once done, you can set a positive reviewon my behalf.
comment:3 Changed 8 years ago by
Commit:  96a07b08bc45dd63e39b64d19589e98dfc6aa06b → 7d5371b50a61ae80ade8129f0045f69848af4966 

Branch pushed to git repo; I updated commit sha1. New commits:
7d5371b  trac #17199 reviewer's comments

comment:4 Changed 8 years ago by
Commit:  7d5371b50a61ae80ade8129f0045f69848af4966 → 1a7465fef0742d7de7ec86c5041df61199345270 

Branch pushed to git repo; I updated commit sha1. New commits:
1a7465f  trac #17199 a few more little typos

comment:5 Changed 8 years ago by
Ok, I have done that, plus a few other minor things. The result is not perfect, but better than before.
comment:8 Changed 8 years ago by
Branch:  u/chapoton/17199 → 1a7465fef0742d7de7ec86c5041df61199345270 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
trac #17xxx little cleanup in multi_polynomial_ideal