Opened 6 years ago

Closed 6 years ago

#17195 closed enhancement (fixed)

Upgrade Cython to 0.21.1

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: robertwb Merged in:
Authors: Jeroen Demeyer Reviewers: Robert Bradshaw
Report Upstream: N/A Work issues:
Branch: 8c69daf (Commits, GitHub, GitLab) Commit: 8c69daf5a4cdbb08f39ca577c9c02bfe483969b9
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This should be an easy upgrade.

Main useful feature for Sage: declarations of the PySlice API.

Rename the upstream tarball to $SAGE_ROOT/upstream/cython-0.21.1.tar.gz

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17195
  • Created changed from 10/22/14 12:21:18 to 10/22/14 12:21:18
  • Modified changed from 10/22/14 12:24:31 to 10/22/14 12:24:31

comment:4 Changed 6 years ago by jdemeyer

  • Commit set to 8c69daf5a4cdbb08f39ca577c9c02bfe483969b9
  • Status changed from new to needs_review

New commits:

8c69dafUpgrade Cython to 0.21.1

comment:5 Changed 6 years ago by robertwb

The changes look fine to me, so positive review pending a clean build and tests passing.

comment:6 Changed 6 years ago by jdemeyer

  • Reviewers set to Robert Bradshaw
  • Status changed from needs_review to positive_review

At least on my machine, it builds fine and passes all tests.

comment:7 Changed 6 years ago by vbraun

I would really appreciate if the upstream tarball instructions don't include manual steps. Just give me a link to a file next time.

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17195 to 8c69daf5a4cdbb08f39ca577c9c02bfe483969b9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.