Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17181 closed defect (fixed)

Poset.__repr__ should mention the linear extension

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorics Keywords:
Cc: hivert, nthiery, nborie, VivianePons, chapoton, aschilling, stumpc5, jmantysalo, tscrim, jhpalmieri Merged in:
Authors: Nathann Cohen Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: 8ec394b (Commits) Commit:
Dependencies: #14019 Stopgaps:

Description

Hello everybody !

A poset with embedded linear extension can never be equal to a "simple poset", and users are bound to wonder someday why two apparently equal posets are not detected as such.

With this branch, this:

sage: Poset(digraphs.Path(5),linear_extension=True)   
Finite poset containing 5 elements

becomes

sage: Poset(digraphs.Path(5),linear_extension=True)   
Finite poset containing 5 elements with embedded linear extension

So that it is clearer that the Poset is 'not only a poset'.

Change History (8)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17181
  • Dependencies set to #14019
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to db2ce313d76bc48a890b19780dd4da01580ec055

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ea330d3revert remove of iterator() and list()
2e4f269Merge remote-tracking branch 'origin/develop' into depr_func
cf77bc2deprecate compact argument
c79991eMerge branch 'u/aapitzsch/ticket/16933' of trac.sagemath.org:sage into public/combinat/poset/fix_equality-14019
e677d31trac #14019: rename _linear_extension to _carries_linear_extension
3afec89renamed _carries_linear_extension to _with_linear_extension
1c0d02dMerge branch 'public/combinat/poset/fix_equality-14019' of trac.sagemath.org:sage into public/combinat/poset/fix_equality-14019
23de9f5Fixing documentation and references.
5c8a641trac #14019: Merged with beta6
db2ce31trac #17181: Poset.__repr__ should mention the linear extension

comment:3 Changed 5 years ago by nthiery

Sounds good to me, thanks! I would just suggest "distinguished" rather than "embedded", since we use that term in similar situations.

The doctest updates raise the question of whether the use of a poset with a linear extension was voluntary or accidental in a couple places (e.g. in the polyhedra code). But fixing those accidental uses can be in a separate ticket.

Modulo this, and assuming that all tests pass, you can set a positive review on my behalf.

Cheers,

Nicolas

comment:4 Changed 5 years ago by git

  • Commit changed from db2ce313d76bc48a890b19780dd4da01580ec055 to 8ec394bed9a5cbd95d3ed4edb7923994af3fb86a

Branch pushed to git repo; I updated commit sha1. New commits:

8ec394btrac #17181: Reviewer's remarks

comment:5 Changed 5 years ago by ncohen

  • Reviewers set to Nicolas Thiery
  • Status changed from needs_review to positive_review

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17181 to 8ec394bed9a5cbd95d3ed4edb7923994af3fb86a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 5 years ago by kcrisman

  • Commit 8ec394bed9a5cbd95d3ed4edb7923994af3fb86a deleted
  • Reviewers changed from Nicolas Thiery to Nicolas Thiéry

Nathann, I thought you knew about accent aigu! ;-) (Actually, I live in perpetual fear of forgetting one somewhere important - it must be even more gauche than forgetting an umlaut in German...)

comment:8 Changed 5 years ago by kcrisman

  • Reviewers changed from Nicolas Thiéry to Nicolas M. Thiéry
Note: See TracTickets for help on using tickets.