Upgrade dot2tex to 2.9.0

[tscrim]

dot2tex 2.9.0 was release in May, 2014. Currently we are at 2.9.0dev, and we should make sure we're at the latest stable release.

Upstream tarball: ​https://pypi.python.org/packages/source/d/dot2tex/dot2tex-2.9.0.tar.gz#md5=2dbaeac905424d0410751235bde4b8b2

[tscrim]

All of our current patches no longer apply because either they were merged upstream or were changes to the testing framework (which has completely changed from the dev version). However I added a new patch which removes the test_semicolon because this is the known, but not yet fixed, ​Issue #5.

---

New commits:

​005d701

Upgrade dot2tex to 2.9.0.

[tscrim]

ping

[chapoton]

with graphviz and this new dot2tex, some trivial doctest failures:

sage -t --optional=sage,dot2tex,graphviz ./graphs/dot2tex_utils.py ./graphs/graph_latex.py ./graphs/generic_graph.py ./categories/crystals.py ./combinat/perfect_matching.py ./combinat/crystals/crystals.py ./combinat/rigged_configurations/kleber_tree.py ./combinat/posets/linear_extensions.py ./combinat/posets/posets.py

---

sage -t graphs/generic_graph.py # 6 doctests failed sage -t combinat/posets/posets.py # 1 doctest failed

---

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​855e55d	Merge branch 'public/optional_spkg/dot2tex-2.9.0-17171' of trac.sagemath.org:sage into public/optional_spkg/dot2tex-2.9.0-17171
​0864610	Fixed trivially failing doctests.

[tscrim]

I fixed the trivially failing doctests (I also made the view() example not tested because it opens a separate window). Looks like this will need to rebased on beta3, which I will do tonight.

[chapoton]

Are you sure that <BLANKLINE> is needed ?

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​1938b1e

Merge branch 'public/optional_spkg/dot2tex-2.9.0-17171' into 6.8.b3

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​159fa6a	Merge branch 'develop' into public/optional_spkg/dot2tex-2.9.0-17171
​758cf08	Merge branch 'public/optional_spkg/dot2tex-2.9.0-17171' of trac.sagemath.org:sage into public/optional_spkg/dot2tex-2.9.0-17171
​8eef83d	Removed blanklines.

[tscrim]

I had done my merge, checking, and was about to push when you did your merge :P.

Turns out the <BLANKLINE>'s are not needed.

[chapoton]

I have a failure:

sage -t combinat/posets/posets.py
**********************************************************************
File "combinat/posets/posets.py", line 1259, in sage.combinat.posets.posets.FinitePoset._latex_
Failed example:
    print P._latex_() #optional - dot2tex graphviz
Expected:
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_1) at (6.0...bp,57.0...bp) [draw,draw=none] {$2$};
      \node (node_0) at (6.0...bp,7.0...bp) [draw,draw=none] {$1$};
      \draw [black,->] (node_0) ..controls (6.0...bp,20.2...bp) and (6.0...bp,30.9...bp)  .. (node_1);
    %
    \end{tikzpicture}
Got:
    <BLANKLINE>
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_1) at (6.0bp,57.0bp) [draw,draw=none] {$2$};
      \node (node_0) at (6.0bp,7.0bp) [draw,draw=none] {$1$};
      \draw [black,->] (node_0) ..controls (6.0bp,19.947bp) and (6.0bp,30.897bp)  .. (node_1);
    %
    \end{tikzpicture}
    <BLANKLINE>

because of the 19 instead of 20

And moreover, it pops me out 10 pdf pictures in new windows..

I did

sage -bt --optional=sage,dot2tex,graphviz ./graphs/__init__.py ./graphs/dot2tex_utils.py ./graphs/graph.py ./graphs/generic_graph.py ./graphs/digraph.py ./graphs/graph_latex.py ./categories/crystals.py ./combinat/perfect_matching.py ./combinat/crystals/crystals.py ./combinat/partition.py ./combinat/posets/posets.py ./combinat/posets/linear_extensions.py ./combinat/rigged_configurations/kleber_tree.py 

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​b7632ca

Making the control points more forgiving.

[tscrim]

That should make that doctest pass.

For better or worse, that was the current behavior before this ticket. However, do you want me to go through and make similar changes with opening external windows?

[jdemeyer]

Small detail:

# not tested - dot2tex, opens external window

should probably be

# optional - dot2tex, not tested (opens external window)

or something.

[chapoton]

well, maybe it would be good, if optionals tests are now going to be run more often..

[jdemeyer]

Replying to chapoton:

well, maybe it would be good, if optionals tests are now going to be run more often..

graphviz isn't optional (it's experimental), so graphviz will not be tested by default.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​7cee4ab

Changing optional tests to not tested because they open an external window.

[tscrim]

I've marked all applicable optional tests as per Jeroen's suggestion.

[jdemeyer]

Replace

optional - dot2tex, graphviz

by

optional - dot2tex graphviz

(like it was before)

[tscrim]

I'm assuming you're refering to

# optional - dot2tex, graphviz, not tested (opens external window)

Do you want it like

# optional - dot2tex graphviz, not tested (opens external window)

(which looks somewhat strange) or

# optional - dot2tex graphviz not tested (opens external window)

(which looks even more strange) or what? I didn't add commas anywhere else that I could see...

[jdemeyer]

Replying to tscrim:

Do you want it like

# optional - dot2tex graphviz, not tested (opens external window)

Yes

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​96cb142

Removing commas.

[tscrim]

Done.

[jdemeyer]

Doctests are good now.

Frédéric, can you do the final review?

[chapoton]

ok, looks good, as far as I can tell.

[vbraun]

src/sage/doctest/sources.py fails

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​2eb080c

Fix doctest/sources failure.

[tscrim]

Fixed. Trivial failure (and there are similar results that are there).

[jdemeyer]

I missed this the last time, but there should be a comma (or other separator) at the @@@ below:

view(H, tight_page=True) # optional - dot2tex@@@ not tested (opens external window)

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​f5a9e93

Adding a missing comma and reverting previous change.

[tscrim]

Fixed.