add "sage -installed" and "sage -pip" commands

[vdelecroix]

Add two commands to sage:

• sage -installed to get the list of installed packages
• sage -pip to run the Python package manager

[vdelecroix]

New commits:

​4bf2330

trac #17155: add "sage -installed" and "sage -pip" commands

[kcrisman]

Huh - and the pip would be quite useful. But even in the chunk you show,

if [ "$1" = '-i' ]; then
     shift
     # If there are no further arguments, simply list all installed

This should even be documented somewhere, but maybe it hasn't been advertised well lately? Not that it would be horrible to add this alias, though I don't know if some syntax warriors will complain because you allow -installed while --installed is the current vogue...

[vdelecroix]

Hello,

Thanks for having a look.

I do not complain that sage -i has not been advertised. But I do that it is documented nowhere (neither in src/bin/sage nor in src/bin/sage-pkg)!

Currently we have the options -optional, -standard and -experimental. I am just adding an additional -installed. We can be smarter and more coherent by allowing multiple arguments and force to use the -i option like in

    $ sage -i --installed --optional --standard
    ... would list all installed package that are either ...
    ... optional or standard                             ...
    $ sage -i --not-installed
    ... would list all non installed packages ...

I am in favour of a more coherent scheme of options, but then we should forbid the older syntax (and instead write a deprecation message that explains the new syntax).

And I definitely do not understand why we do have two scripts (src/bin/sage-spkg and src/bin/sage-list-packages) for dealing with packages. Morever the current state is that sage-spkg is used to list the installed packages while sage-list-packages is the one to list the optional packages...

EDIT: and I just noticed that the sage -i starts with a useless line 'Currently installed packages:'. It is especially bad if you want to use it in other scripts.

Vincent

[kcrisman]

And I definitely do not understand why we do have two scripts

Alas, I can only point things out when it comes to these scripts - I am reluctant to tread on such long-standing traditions. I do hope some others come to look at this, though, since at the very least it is not bad to add -installed.

[jdemeyer]

Use spaces, not TABs for indentation.

Instead of [ ! $(sage -installed | grep -c '^pip-') -eq 1 ], I would go with [ -x "$SAGE_LOCAL/bin/pip" ]

And why not replace echo "Pip is not installed. Run \"sage -i pip\" to install it." by sage -i pip || exit $??

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​6ae094b

trac #17155: reviewer comments

[vdelecroix]

Replying to jdemeyer:

Use spaces, not TABs for indentation.

Instead of [ ! $(sage -installed | grep -c '^pip-') -eq 1 ], I would go with [ -x "$SAGE_LOCAL/bin/pip" ]

done. It is much simpler, thanks.

And why not replace echo "Pip is not installed. Run \"sage -i pip\" to install it." by sage -i pip || exit $??

I do not like to do things in a script that users did not ask for.

Vincent

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​0ded194

trac #17155: reviewer comments

[jdemeyer]

If you deprecate something, it should still work (i.e. don't remove the old code, just add the echo statements).

Also, please use echo >&2 for these warnings.

[jdemeyer]

In --help, you write -installed while only --installed works. I think you should stick to the de facto convention that both single and double dashes should work.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​31c2fec

trac #17155: nicer deprecation

[jdemeyer]

In sage-list-packages:

• "standard -> "standard"
• except A, B -> except A as B
• The except clause should abort the program otherwise one gets

  Traceback (most recent call last):
    File "/usr/local/src/sage-config/src/bin/sage-list-packages", line 80, in <module>
      available_version = dict([ split_pkgname(pkg) for pkg in get_remote_package_list(category)])
  TypeError: 'int' object is not iterable
  

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​9810c8c

trac #17155: reviewer comments

[vdelecroix]

Thanks for your comments. I did all the modifications in my last commit.

[vdelecroix]

ping!

[vdelecroix]

Thanks.