Opened 12 years ago

Closed 12 years ago

#1714 closed enhancement (fixed)

[with patch, with positive review] allow keyword arguments for remote sage methods (sage0)

Reported by: malb Owned by: was
Priority: major Milestone: sage-2.10.2
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

keyword arguments were not passed through to the remote sage instance now they are.

Attachments (2)

sage0_keywords.patch (1.8 KB) - added by malb 12 years ago.
sage0_keywords.2.patch (1.6 KB) - added by malb 12 years ago.
rebased patch against 2.10.1.rc2 (without cputime method)

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by malb

comment:1 Changed 12 years ago by mabshoff

Since #1843 has been merged this patch needs to be revisited now.

Cheers,

Michael

Changed 12 years ago by malb

rebased patch against 2.10.1.rc2 (without cputime method)

comment:2 Changed 12 years ago by malb

  • Type changed from defect to enhancement

The new attached patch sage0_keywords.2.patch which replaces the old patch applies cleanly against 2.10.1.rc2.

comment:3 Changed 12 years ago by ncalexan

  • Summary changed from [with patch, needs review] allow keyword arguments for remote sage methods (sage0) to [with patch, with positive review] allow keyword arguments for remote sage methods (sage0)

Second patch looks fine, I say apply.

There are no docstrings, but is this code even doctested? I don't know.

comment:4 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged sage0_keywords.2.patch in Sage 2.10.2.alpha0

Note: See TracTickets for help on using tickets.