Opened 7 years ago

Closed 7 years ago

#17136 closed defect (fixed)

upgrade latte_int to 1.7.1, and fix the gmp config error

Reported by: dimpase Owned by:
Priority: major Milestone: sage-6.4
Component: packages: experimental Keywords:
Cc: vdelecroix, nthiery Merged in:
Authors: Dima Pasechnik Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 8a41188 (Commits, GitHub, GitLab) Commit: 8a41188791f5fecacefda08886296c9f8bbbc0f1
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

as reported, gmp currently needs to be installed to build latte_int, otherwise configure fails. The fix for this is to add --with-gmp=$SAGE_LOCAL to the list of configure parameters in spkg-install.

Besides, latte_int is now version 1.7.1, not 1.6 (shipped now).

The link to tarball, to place in SAGEROOT/upstream', before trying sage -f latte_int`.

Change History (10)

comment:1 Changed 7 years ago by dimpase

  • Authors set to Dima Pasechnik
  • Branch set to u/dimpase/17136
  • Commit set to 5542788cb86eaa3d5e135cdbd0e1b5e274394ac6
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

5542788new layout, update, and fix for latte_int

comment:2 Changed 7 years ago by dimpase

  • Cc vdelecroix nthiery added

comment:3 Changed 7 years ago by dimpase

I've updated the setup to follow the new spkg layout. So a reviewer will need to checkout the corresponding git branch and copy the upstream tarball by hand, as mentioned in the ticket description.

comment:4 follow-up: Changed 7 years ago by vdelecroix

I just download the tarball and it installs fine! Thanks.

I will play a bit with latte and see if everything is fine.

Vincent

comment:5 in reply to: ↑ 4 Changed 7 years ago by dimpase

Replying to vdelecroix:

I just download the tarball and it installs fine! Thanks.

I will play a bit with latte and see if everything is fine.

I tried installing it with SAGE_CHECK=yes and it did pass all the tests there.

comment:6 Changed 7 years ago by vdelecroix

  • Branch changed from u/dimpase/17136 to u/vdelecroix/17136
  • Commit changed from 5542788cb86eaa3d5e135cdbd0e1b5e274394ac6 to 8a41188791f5fecacefda08886296c9f8bbbc0f1

Hi,

I just pushed one commit where I removed the trailing whitespaces that you introduced. If it is ok, you can set to positive review.

Vincent


New commits:

8a41188trac #17136: remove trailing whitespaces

comment:7 Changed 7 years ago by dimpase

  • Status changed from needs_review to positive_review

ok, thanks!

comment:8 Changed 7 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:9 Changed 7 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_work to positive_review

comment:10 Changed 7 years ago by vbraun

  • Branch changed from u/vdelecroix/17136 to 8a41188791f5fecacefda08886296c9f8bbbc0f1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.