Opened 4 years ago

Closed 4 years ago

#17111 closed defect (fixed)

Sage is missing one letter

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: b802bf8 (Commits) Commit: b802bf8b46ab1a603ecc4ec69c04650db8bf382e
Dependencies: #17034 Stopgaps:

Description

After #17034 Sage reports : 

sage: designs.orthogonal_arrays.explain_construction(10,154)
'the database contains a (154,10;1,0;17)-quasi difference matrix'

But we have no (154,10;1,0;17)-QDM. Here is what it should be: 

sage: designs.orthogonal_arrays.explain_construction(10,154)
'the database contains a (137,10;1,0;17)-quasi difference matrix'

And this is because of a missing 'n'

Nathann

Change History (11)

comment:1 Changed 4 years ago by ncohen

  • Branch set to u/ncohen/17111
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to 223e1d5e320dd60d4e9f531ab06d12f0eba4eb5c

Branch pushed to git repo; I updated commit sha1. New commits:

​799845atrac #17034: New user interface for orthogonal arrays and a .explain_construction method
​e37125btrac #17034: Bugfix
​3bf5400trac #17034: documentation
​024f0b3trac #17034: Reviewer's remark
​c7eae7dtrac #17034: move the user functions into OAMainFunctions
​b046793trac #17034: assert has been declared illegal
​b9516b1trac #17034: Broken doctest
​223e1d5trac #17111: Sage is missing one letter

comment:3 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to positive_review

All right.

Vincent

comment:4 follow-up: Changed 4 years ago by ncohen

Thanks !

(I am working on a design patch at the moment. For incomplete orthogonal arrays. But I don't know how to write it yet :-/)

comment:5 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

comment:6 in reply to: ↑ 4 ; follow-up: Changed 4 years ago by vdelecroix

Replying to ncohen:

(I am working on a design patch at the moment. For incomplete orthogonal arrays. But I don't know how to write it yet :-/)

... never ending story :-)

comment:7 in reply to: ↑ 6 Changed 4 years ago by ncohen

... never ending story :-)

Not really. The does not remain SOOOOO many OA to build. Then it will be the researcher's turn to build new ones !

Nathann

comment:8 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work 
sage -t --long --warn-long 67.8 src/sage/combinat/designs/orthogonal_arrays.py
**********************************************************************
File "src/sage/combinat/designs/orthogonal_arrays.py", line 1871, in sage.combinat.designs.orthogonal_arrays.OAMainFunctions.explain_construction
Failed example:
    designs.orthogonal_arrays.explain_construction(10,154)
Expected:
    "the database contains a (137,10;1,0;17)-quasi difference matrix"
Got:
    'the database contains a (137,10;1,0;17)-quasi difference matrix'
**********************************************************************
1 item had failures:
   1 of   3 in sage.combinat.designs.orthogonal_arrays.OAMainFunctions.explain_construction
    [155 tests, 1 failure, 1.77 s]
----------------------------------------------------------------------
sage -t --long --warn-long 67.8 src/sage/combinat/designs/orthogonal_arrays.py  # 1 doctest failed
----------------------------------------------------------------------

comment:9 Changed 4 years ago by git

  • Commit changed from 223e1d5e320dd60d4e9f531ab06d12f0eba4eb5c to b802bf8b46ab1a603ecc4ec69c04650db8bf382e

Branch pushed to git repo; I updated commit sha1. New commits:

​a7cfb2etrac #17111: Merged with beta5
​b802bf8trac #17111: Broken doctest

comment:10 Changed 4 years ago by ncohen

  • Status changed from needs_work to positive_review

Sorry... :-/

Nathann

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/ncohen/17111 to b802bf8b46ab1a603ecc4ec69c04650db8bf382e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.