Opened 5 years ago

Closed 5 years ago

#17110 closed defect (fixed)

Graphs, off-by-one check in static sparce backend

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-6.4
Component: graph theory Keywords:
Cc: ncohen Merged in:
Authors: Nathann Cohen Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: f4f70b8 (Commits) Commit: f4f70b874f1b722d3a19c4a797efc6f151a344bb
Dependencies: Stopgaps:

Description

P=Posets.PentagonPoset()
for i in range(0,7): print P._hasse_diagram._backend._cg.in_degree(i)

I think that at static_sparse_backend.pyx in three places u>self.g.n should be u>=self.g.n.

Change History (4)

comment:1 Changed 5 years ago by ncohen

  • Authors set to Nathann Cohen
  • Branch set to u/ncohen/17110
  • Status changed from new to needs_review

Sorry for that. It is fixed in this branch.

Nathann

comment:2 Changed 5 years ago by git

  • Commit set to f4f70b874f1b722d3a19c4a797efc6f151a344bb

Branch pushed to git repo; I updated commit sha1. New commits:

f4f70b8trac #17110: Off-by-one check in static sparce backend

comment:3 Changed 5 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo
  • Status changed from needs_review to positive_review

Nathann, the cowboy that fixes bugs faster than his shadow. Works.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17110 to f4f70b874f1b722d3a19c4a797efc6f151a344bb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.