Opened 8 years ago

Closed 8 years ago

#17087 closed enhancement (fixed)

Clean up fflas-ffpack and linbox

Reported by: François Bissey Owned by:
Priority: minor Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: Jean-Pierre Flori Merged in:
Authors: François Bissey Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: c3e138b (Commits, GitHub, GitLab) Commit: c3e138b8c9a8c543b2268603d440fb9900bc7036
Dependencies: Stopgaps:

Status badges

Description

The packages fflas-ffpack and linbox work in tandem and have unnecessary complex setup to deal with blas. This ticket aims to simplify the spkgs by removing the useless bits and tidying the bits relating to blas.

Change History (8)

comment:1 Changed 8 years ago by François Bissey

Branch: u/fbissey/linbox_blas
Commit: c3e138b8c9a8c543b2268603d440fb9900bc7036

The only question I have left before finalizing the ticket is whether we keep the possibility to set the variable LINBOX_BLAS externally to override whatever default there is. I am for removing it now as we will want to remove it anyway once we push #17075 in earnest.

comment:2 Changed 8 years ago by François Bissey

Cc: Jean-Pierre Flori added
Status: newneeds_review

Jean-Pierre, can you review this clean up?

comment:3 Changed 8 years ago by Jean-Pierre Flori

Status: needs_reviewpositive_review

Looks OK but untested as I don't have access to a computer. Lets trust the patchbot.

comment:4 Changed 8 years ago by Volker Braun

Status: positive_reviewneeds_work

author/reviewer name

How did you write the last comment without computer? Carrier pigeon? ;-)

comment:5 Changed 8 years ago by Jean-Pierre Flori

Mobile phone...

comment:6 Changed 8 years ago by François Bissey

Authors: François Bissey
Reviewers: Jean-Pierre Flori
Status: needs_workneeds_review

comment:7 Changed 8 years ago by François Bissey

Status: needs_reviewpositive_review

comment:8 Changed 8 years ago by Volker Braun

Branch: u/fbissey/linbox_blasc3e138b8c9a8c543b2268603d440fb9900bc7036
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.