Opened 6 years ago

Closed 6 years ago

#17087 closed enhancement (fixed)

Clean up fflas-ffpack and linbox

Reported by: fbissey Owned by:
Priority: minor Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: jpflori Merged in:
Authors: François Bissey Reviewers: Jean-Pierre Flori
Report Upstream: N/A Work issues:
Branch: c3e138b (Commits) Commit: c3e138b8c9a8c543b2268603d440fb9900bc7036
Dependencies: Stopgaps:

Description

The packages fflas-ffpack and linbox work in tandem and have unnecessary complex setup to deal with blas. This ticket aims to simplify the spkgs by removing the useless bits and tidying the bits relating to blas.

Change History (8)

comment:1 Changed 6 years ago by fbissey

  • Branch set to u/fbissey/linbox_blas
  • Commit set to c3e138b8c9a8c543b2268603d440fb9900bc7036

The only question I have left before finalizing the ticket is whether we keep the possibility to set the variable LINBOX_BLAS externally to override whatever default there is. I am for removing it now as we will want to remove it anyway once we push #17075 in earnest.

comment:2 Changed 6 years ago by fbissey

  • Cc jpflori added
  • Status changed from new to needs_review

Jean-Pierre, can you review this clean up?

comment:3 Changed 6 years ago by jpflori

  • Status changed from needs_review to positive_review

Looks OK but untested as I don't have access to a computer. Lets trust the patchbot.

comment:4 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

author/reviewer name

How did you write the last comment without computer? Carrier pigeon? ;-)

comment:5 Changed 6 years ago by jpflori

Mobile phone...

comment:6 Changed 6 years ago by fbissey

  • Authors set to François Bissey
  • Reviewers set to Jean-Pierre Flori
  • Status changed from needs_work to needs_review

comment:7 Changed 6 years ago by fbissey

  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/fbissey/linbox_blas to c3e138b8c9a8c543b2268603d440fb9900bc7036
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.