Opened 8 years ago

Closed 8 years ago

#17076 closed enhancement (fixed)

Fix some exception handling

Reported by: Jeroen Demeyer Owned by:
Priority: minor Milestone: sage-6.4
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: fcba17f (Commits, GitHub, GitLab) Commit: fcba17ff4c500f136a3fcfad68f91905b4b3989b
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Change except: by except Exception: and fix some dubious uses of AssertionError.

Change History (7)

comment:1 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:2 Changed 8 years ago by Jeroen Demeyer

Summary: Fix some except clausesFix some exception handling

comment:3 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/17076
Created: Sep 30, 2014, 7:20:17 PMSep 30, 2014, 7:20:17 PM
Modified: Oct 1, 2014, 7:50:07 AMOct 1, 2014, 7:50:07 AM

comment:4 Changed 8 years ago by Jeroen Demeyer

Commit: df1e39729174679a4f651483636d484429264c76
Status: newneeds_review

New commits:

df1e397Fix some exception handling

comment:5 Changed 8 years ago by git

Commit: df1e39729174679a4f651483636d484429264c76fcba17ff4c500f136a3fcfad68f91905b4b3989b

Branch pushed to git repo; I updated commit sha1. New commits:

e23be2f17106: fix assert in sage.misc.c3_controlled doctest
20e8ec717106: fix indentation
fcba17fMerge remote-tracking branch 'origin/u/nthiery/fix_assert_in_sage_misc_c3_controlled' into ticket/17076

comment:6 Changed 8 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

Looks good to me.

comment:7 Changed 8 years ago by Volker Braun

Branch: u/jdemeyer/ticket/17076fcba17ff4c500f136a3fcfad68f91905b4b3989b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.