Opened 6 years ago

Closed 6 years ago

#17064 closed defect (fixed)

Convert `database_odlyzko_zeta` to new-style package

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-6.5
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: ee6ccaf (Commits) Commit: ee6ccaf10f4a65cfb1e34d832a1d4e5a9a0e0be7
Dependencies: #17460, #14396 Stopgaps:

Description (last modified by jdemeyer)

It was broken anyway (using $SAGE_ROOT/data instead of $SAGE_SHARE). Also create the pickle at install time, analogous to conway_polynomials.

Package: http://boxen.math.washington.edu/home/jdemeyer/spkg/database_odlyzko_zeta-20061209.tar.bz2

Change History (14)

comment:1 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Dependencies set to #17460
  • Milestone changed from sage-6.4 to sage-6.5

comment:2 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Installing database_odlyzko_zeta fails, dir "data" is not created to Convert `database_odlyzko_zeta` to new-style package

comment:3 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17064
  • Created changed from 09/28/14 20:49:42 to 09/28/14 20:49:42
  • Modified changed from 01/20/15 16:45:01 to 01/20/15 16:45:01

comment:4 Changed 6 years ago by jdemeyer

  • Commit set to a50cb401fdb41937c3aabf676d1adb315bcfe634
  • Status changed from new to needs_review

New commits:

d12c094Deprecate moved imports from sage.misc.misc
a50cb40Add new-style package database_odlyzko_zeta

comment:5 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 6 years ago by kcrisman

  • Status changed from needs_review to needs_work

I'm not sure why but the branch is red.

comment:8 Changed 6 years ago by git

  • Commit changed from a50cb401fdb41937c3aabf676d1adb315bcfe634 to ee6ccaf10f4a65cfb1e34d832a1d4e5a9a0e0be7

Branch pushed to git repo; I updated commit sha1. New commits:

026b281Merge ticket/14396 into ticket/17460
92de9fcMake tests 32/64-bit independent
ee6ccafMerge ticket/17460 into ticket/17064

comment:9 Changed 6 years ago by jdemeyer

  • Dependencies changed from #17460 to #17460, #14396
  • Status changed from needs_work to needs_review

The conflict was between #17460 and #14396. This was fixed in #17460 but that fix was not yet merged in the branch here.

comment:10 Changed 6 years ago by jdemeyer

The only "real" commit for this ticket is

a50cb40Add new-style package database_odlyzko_zeta

The rest are merges from other tickets.

comment:11 Changed 6 years ago by jdemeyer

This ticket is in fact a good example of why we should have review-without-dependencies like I always argued for. There was a conflict which was only in the dependency and which was also fixed in the dependency.

The release manager wouldn't have seen this conflict since he would first merge the dependencies (fixing the conflict), then this ticket. If the "review view" of tickets would do the same thing (show the difference between develop+dependencies and develop+dependencies+ticket), there wouldn't have been a red link.

comment:12 Changed 6 years ago by kcrisman

If the "review view" of tickets would do the same thing (show the difference between develop+dependencies and develop+dependencies+ticket), there wouldn't have been a red link.

Interesting, I wasn't aware of that. The patchbot supposedly would have taken that into account, but I haven't seen many patchbot results lately - right now I get a 503, in fact.

comment:13 Changed 6 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

Seems fine.

comment:14 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17064 to ee6ccaf10f4a65cfb1e34d832a1d4e5a9a0e0be7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.