Opened 7 years ago

Closed 7 years ago

#17061 closed defect (duplicate)

Posets.DiamondPoset, some corrections

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jmantysalo/posets_diamondposet__some_corrections (Commits, GitHub, GitLab) Commit: 65569928253276a136e7df2a38d14cd90b5f5daa
Dependencies: Stopgaps:

Status badges

Description

I think that Posets.DiamondPoset() should have facade=True as default, see #17051.

Also Posets.DiamondPoset(2) returns empty poset, DiamondPoset(1) gives error message. Should they both just complain about wrong argument?

Change History (6)

comment:1 Changed 7 years ago by jmantysalo

  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 7 years ago by jmantysalo

  • Branch set to u/jmantysalo/posets_diamondposet__some_corrections

comment:3 Changed 7 years ago by jmantysalo

  • Authors set to Jori Mäntysalo
  • Commit set to 65569928253276a136e7df2a38d14cd90b5f5daa
  • Status changed from new to needs_review

Simple corrections.


New commits:

6556992DiamondPoset(n) now gives error if n<3. Also default value for

comment:4 Changed 7 years ago by ncohen

Oh I see. You could have fixed that in the PentagonPoset ticket.

Nathann

comment:5 Changed 7 years ago by jmantysalo

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

Moved code to another ticket as suggested by ncohen.

comment:6 Changed 7 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.