Opened 7 years ago

Closed 6 years ago

#17057 closed defect (wontfix)

show() does not check for figsize value

Reported by: jmantysalo Owned by:
Priority: trivial Milestone: sage-duplicate/invalid/wontfix
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers: Karl-Dieter Crisman, ​Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

For example Poset({0:[1]}).show(figsize=0) complains about singular matrix, and also figsize='cat-says-meow' is not detected as it should. And more, figsize=32767 should not answer "width and height must each be below 32768".

Change History (4)

comment:1 Changed 6 years ago by kcrisman

Take a look at #5956 (presumably will appear in the next beta, isn't in 6.5.beta0). I think that should catch the string problem and zero problem. We could conceivably add even more tests for those.

The other problem is user error, in some sense, now that we document what that means, but we could try to catch that as well.

comment:2 Changed 6 years ago by jmantysalo

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

This is fine for me. I'll mark this as duplicate/wontfix. (So please click to positive review.)

comment:3 Changed 6 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman, ​Jori Mäntysalo
  • Status changed from needs_review to positive_review

comment:4 Changed 6 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.