Opened 4 years ago
Closed 4 years ago
#17047 closed enhancement (fixed)
Isomorphism of incidence structures
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | combinatorial designs | Keywords: | |
Cc: | vdelecroix, dimpase | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | a7be076 (Commits) | Commit: | a7be076f3f68804ca4e50801addb858e1f89e2f9 |
Dependencies: | Stopgaps: |
Description
Heeeeeere it is !
Adds three functions: is_isomorphic
, canonical_label
, and copy
(I needed that).
Nathann
Change History (14)
comment:1 Changed 4 years ago by
- Branch set to u/ncohen/17047
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Commit set to fb2829d5181adf3c676e3a02ebf62168726691ab
comment:3 Changed 4 years ago by
shouldn't you do g=Graph(data_structure="static_sparse")
rather than the default Graph
?
comment:4 Changed 4 years ago by
I am not sure what exactly the code does with respect to the data structure. Perhaps it copies it, I am not sure O_o
Nathann
comment:5 Changed 4 years ago by
Either way I don't think that this code should do that. If the isomorphism code is faster with static graphs, then it should do a copy itself.
Creating a static graph is the same as creating it with the 'normal' data structure then copying it into a static version anyway.
Nathann
comment:6 Changed 4 years ago by
Ping ?
comment:7 Changed 4 years ago by
- Component changed from combinatorics to combinatorial designs
comment:8 Changed 4 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
LGTM
comment:9 Changed 4 years ago by
Thanks !
Nathann
comment:10 Changed 4 years ago by
- Branch changed from u/ncohen/17047 to fb2829d5181adf3c676e3a02ebf62168726691ab
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 4 years ago by
- Commit fb2829d5181adf3c676e3a02ebf62168726691ab deleted
- Resolution fixed deleted
- Status changed from closed to new
sage -t --long src/sage/combinat/designs/incidence_structures.py ********************************************************************** File "src/sage/combinat/designs/incidence_structures.py", line 560, in sage.combinat.designs.incidence_structures.IncidenceStructure.copy Failed example: IS.blocks() Expected: [[1, 2, 3, 'e']] Got: [['e', 1, 2, 3]] ********************************************************************** File "src/sage/combinat/designs/incidence_structures.py", line 566, in sage.combinat.designs.incidence_structures.IncidenceStructure.copy Failed example: copy(IS).blocks() Expected: [[1, 2, 3, 'e']] Got: [['e', 1, 2, 3]] ********************************************************************** 1 item had failures: 2 of 7 in sage.combinat.designs.incidence_structures.IncidenceStructure.copy [279 tests, 2 failures, 1.99 s]
comment:12 Changed 4 years ago by
- Branch changed from fb2829d5181adf3c676e3a02ebf62168726691ab to u/ncohen/17047
- Commit set to a7be076f3f68804ca4e50801addb858e1f89e2f9
- Status changed from new to needs_review
comment:13 Changed 4 years ago by
- Status changed from needs_review to positive_review
comment:14 Changed 4 years ago by
- Branch changed from u/ncohen/17047 to a7be076f3f68804ca4e50801addb858e1f89e2f9
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #17047: Isomorphism of incidence structures