Opened 6 years ago

Closed 6 years ago

#17046 closed defect (duplicate)

Finite poset, directed_subsets() doesn't check for argument

Reported by: jmantysalo Owned by:
Priority: trivial Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #17045 Stopgaps:

Description 

Poset({0:[1]}).directed_subsets('cat-says-meow')

does not give error message. It should accept only 'up' and 'down'.

Change History (6)

comment:1 Changed 6 years ago by jmantysalo

  • Branch set to u/jmantysalo/finite_poset__directed_subsets___doesn_t_check_for_argument

comment:2 Changed 6 years ago by jmantysalo

  • Commit set to a401c7fc3e8cf7064d50fa64614f5af1f66979d1
  • Status changed from new to needs_review

New commits:

​a401c7fAdded check: direction must be 'up' or 'down'.

comment:3 Changed 6 years ago by jmantysalo

  • Merged in set to #17045
  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix

Merged this to #17045 as asked by ncohen. This one can be closed.

comment:4 Changed 6 years ago by ncohen

  • Status changed from needs_review to positive_review

wontfix -> positive review

comment:5 Changed 6 years ago by jdemeyer

  • Branch u/jmantysalo/finite_poset__directed_subsets___doesn_t_check_for_argument deleted
  • Commit a401c7fc3e8cf7064d50fa64614f5af1f66979d1 deleted
  • Dependencies set to #17045
  • Merged in #17045 deleted

comment:6 Changed 6 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.