Opened 12 years ago

Closed 12 years ago

#1704 closed enhancement (fixed)

[with patch, with positive review] replace _DivPolyContext by _multiply_point

Reported by: dmharvey Owned by: was
Priority: major Milestone: sage-2.10.1
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch replaces the _DivPolyContext class with a new function _multiply_point. The main downside of the original _DivPolyContext is that it's very recursive, and I started overflowing python's stack for some large problems I needed to play with. The new function is not recursive, and also turns out to be slightly faster.

Attachments (1)

multiply_point.hg (2.5 KB) - added by dmharvey 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by dmharvey

comment:1 Changed 12 years ago by ncalexan

I can't speak to mathematical correctness, but the patch looks good to me. Apply.

comment:2 Changed 12 years ago by ncalexan

  • Summary changed from [with patch] replace _DivPolyContext by _multiply_point to [with patch, with positive review] replace _DivPolyContext by _multiply_point

comment:3 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.