Opened 7 years ago

Closed 6 years ago

#17028 closed enhancement (fixed)

Implement conversion vector -> PARI

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.4
Component: interfaces Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: 41e01da (Commits, GitHub, GitLab) Commit: 41e01daaec8f61137b5e115a52feb8c634d933fb
Dependencies: Stopgaps:

Status badges

Description

sage: vector([1,2,3])._pari_()
---------------------------------------------------------------------------
PariError                                 Traceback (most recent call last)
<ipython-input-1-6900c300f3dc> in <module>()
----> 1 vector([Integer(1),Integer(2),Integer(3)])._pari_()

/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/structure/sage_object.so in sage.structure.sage_object.SageObject._pari_ (build/cythonized/sage/structure/sage_object.c:9879)()

/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/libs/pari/pari_instance.so in sage.libs.pari.pari_instance.PariInstance.__call__ (build/cythonized/sage/libs/pari/pari_instance.c:6323)()

/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/libs/pari/gen.so in sage.libs.pari.gen.objtogen (build/cythonized/sage/libs/pari/gen.c:52798)()

/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/libs/pari/handle_error.so in sage.libs.pari.handle_error._pari_handle_exception (build/cythonized/sage/libs/pari/handle_error.c:1104)()

PariError: syntax error, unexpected ')', expecting )-> or ',': (1,2,3)

Change History (8)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/17028
  • Created changed from 09/23/14 12:18:46 to 09/23/14 12:18:46
  • Modified changed from 09/23/14 12:18:46 to 09/23/14 12:18:46

comment:2 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 6c452346bb2463d0f0a96f60cf4fb4ddb67b65f5
  • Status changed from new to needs_review

New commits:

6c45234Implement conversion vector -> PARI

comment:3 Changed 6 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to needs_work

Doctest failures (on top of 6.5.beta0):

sage -t --long --warn-long 53.7 src/sage/matrix/matrix2.pyx  # 1 doctest failed
sage -t --long --warn-long 53.7 src/sage/libs/pari/gen_py.py  # 1 doctest failed

comment:4 Changed 6 years ago by jdemeyer

Sorry for that, I set to needs_review without testing apparently...

comment:5 Changed 6 years ago by git

  • Commit changed from 6c452346bb2463d0f0a96f60cf4fb4ddb67b65f5 to 41e01daaec8f61137b5e115a52feb8c634d933fb

Branch pushed to git repo; I updated commit sha1. New commits:

6541a9cMerge remote-tracking branch 'origin/develop' into ticket/17028
41e01daFix matrix solve_right() after changing vector -> PARI conversion

comment:6 Changed 6 years ago by jdemeyer

  • Modified changed from 11/18/14 14:41:46 to 11/18/14 14:41:46
  • Status changed from needs_work to needs_review

comment:7 Changed 6 years ago by pbruin

  • Status changed from needs_review to positive_review

comment:8 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/17028 to 41e01daaec8f61137b5e115a52feb8c634d933fb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.