Opened 6 years ago

Closed 6 years ago

#17024 closed defect (fixed)

Bring back the p-adic gamma function

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.4
Component: basic arithmetic Keywords:
Cc: asalerno, chapoton Merged in:
Authors: Beth Malmskog, Adriana Salerno, Christelle Vincent, Ursula Whitcher Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 6cb5f85 (Commits) Commit: 6cb5f856a39554696d4a2e755142740e9fe8a10c
Dependencies: Stopgaps:

Description (last modified by vbraun)

#14880 implemented the p-adic gamma function and Dwork expanison, but it seems that this was lost in the template rewrite #12555. Or maybe in the fog of war of the git transition. In any case, here it is again.

Change History (10)

comment:1 Changed 6 years ago by vbraun

  • Component changed from PLEASE CHANGE to basic arithmetic
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/bring_back_the_p_adic_gamma_function

comment:3 Changed 6 years ago by vbraun

  • Commit set to 68cb217f11d74013118f17a91ff68ada63cafe8e
  • Description modified (diff)

New commits:

68cb217Implement the padic gamma function

comment:4 Changed 6 years ago by vbraun

  • Authors set to Beth Malmskog, Adriana Salerno, Christelle Vincent, Ursula Whitcher
  • Cc asalerno chapoton added
  • Status changed from new to needs_review

comment:5 Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

The keyword for choosing the algorithm should be called algorithm, not flag.

comment:6 Changed 6 years ago by jdemeyer

When using the PARI algorithm, the answer should be converted back to the correct Sage parent.

comment:7 Changed 6 years ago by git

  • Commit changed from 68cb217f11d74013118f17a91ff68ada63cafe8e to 6cb5f856a39554696d4a2e755142740e9fe8a10c

Branch pushed to git repo; I updated commit sha1. New commits:

6cb5f85Rename flag->algorithm and convert to same parent

comment:8 Changed 6 years ago by vbraun

Thanks, fixed.

comment:9 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to positive_review

The "sage" algorithm doesn't work as well as "pari":

sage: Zp(2)(1).gamma("sage")
1 + 2 + 2^2 + 2^3 + 2^4 + 2^5 + 2^6 + 2^7 + 2^8 + 2^9 + 2^10 + 2^11 + 2^12 + 2^13 + 2^14 + 2^15 + 2^16 + 2^17 + 2^18 + O(2^19)

(precision only 19 instead of 20)

sage: ZpFM(17).random_element().gamma("sage")
...
ValueError: cannot invert non-unit

("sage" algorithm doesn't work for ZpFM)

But since it's not the default, I'll let it be.

comment:10 Changed 6 years ago by vbraun

  • Branch changed from u/vbraun/bring_back_the_p_adic_gamma_function to 6cb5f856a39554696d4a2e755142740e9fe8a10c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.